Introduce podman IPv6 test #19011
Merged
Introduce podman IPv6 test #19011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pdostal
commented
Apr 3, 2024
•
pdostal
commented
- Introduce podman IPv6 test
- This is also testing our registry via IPv6
- Do not merge before: gitlab.suse.de/qac/qac-openqa-yaml!1575
- Related ticket: poo#138197, poo#134783
- Verification run: SLES 15-SP5 GCE, SLES 15-SP6 GCE
pdostal
requested review from
grisu48,
jlausuch,
mloviska,
ricardobranco777 and
asmorodskyi
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
ricardobranco777
approved these changes
Apr 3, 2024
We don't run Factory on GCE. |
But why run this test only on cloud? |
|
Because from O3 and from OSD we don't have IPv6 access. |
grisu48
reviewed
Apr 4, 2024
asmorodskyi
reviewed
Apr 4, 2024
lib/main_containers.pm
Outdated
| @@ -133,6 +134,7 @@ sub load_host_tests_podman { | |||
| load_firewall_test($run_args) unless (is_public_cloud || is_openstack || is_microos || is_alp); | |||
| # Netavark not supported in 15-SP1 and 15-SP2 (due to podman version older than 4.0.0) | |||
| loadtest 'containers/podman_netavark' unless (is_staging || is_sle("<15-sp3") || is_ppc64le); | |||
| loadtest 'containers/podman_ipv6' if (is_public_cloud && is_gce && is_sle('>=15-SP5')); | |||
There was a problem hiding this comment.
Suggested change
| loadtest 'containers/podman_ipv6' if (is_public_cloud && is_gce && is_sle('>=15-SP5')); | |
| loadtest 'containers/podman_ipv6' if ( is_gce() && is_sle('>=15-SP5')); |
is_public_cloud() is part of is_gce() so no need to call it second time
asmorodskyi
reviewed
Apr 4, 2024
tests/containers/podman_ipv6.pm
Outdated
| @@ -0,0 +1,89 @@ | |||
| # SUSE's openQA tests | |||
| # | |||
| # Copyright 2023-2024 SUSE LLC | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2023-2024 SUSE LLC | |
| # Copyright 2024 SUSE LLC |
asmorodskyi
reviewed
Apr 4, 2024
pdostal
force-pushed
the
podman_ipv6
branch
2 times, most recently
from
70f826d
to
736d07a
Compare
ricardobranco777
approved these changes
Apr 4, 2024
pdostal
force-pushed
the
podman_ipv6
branch
2 times, most recently
from
88adaae
to
49dbdd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.