Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test suite which enables FIPS and runs container hosts tests #19076

Conversation

@os-autoinst os-autoinst deleted a comment from github-actions bot Apr 11, 2024
@pablo-herranz pablo-herranz force-pushed the poo138428_test-container-engines-in-FIPS-mode branch from 3171e81 to ec6bc33 Compare April 11, 2024 05:33

This comment was marked as resolved.

@pablo-herranz pablo-herranz force-pushed the poo138428_test-container-engines-in-FIPS-mode branch from ec6bc33 to 1879ab6 Compare April 11, 2024 05:35
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't it was really that simple!

LGTM.

@pablo-herranz pablo-herranz marked this pull request as ready for review April 11, 2024 08:01
@pablo-herranz
Copy link
Contributor Author

Didn't it was really that simple!

LGTM.

Neither did I, in fact I'm a bit skeptical that it was so smooth...

Copy link
Member

@mgrossu mgrossu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-herranz pablo-herranz marked this pull request as draft April 11, 2024 10:14
@pablo-herranz pablo-herranz force-pushed the poo138428_test-container-engines-in-FIPS-mode branch 2 times, most recently from 1914994 to fd2ec15 Compare April 11, 2024 10:30
Also prevented `fips_setup` from running twice
@pablo-herranz pablo-herranz force-pushed the poo138428_test-container-engines-in-FIPS-mode branch from fd2ec15 to 034b992 Compare April 11, 2024 10:34
@pablo-herranz pablo-herranz marked this pull request as ready for review April 11, 2024 12:29
Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@grisu48 grisu48 merged commit 1e2c331 into os-autoinst:master Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants