Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network configuration on s390x for slem NM test #19205

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

rfan1
Copy link
Contributor

@rfan1 rfan1 commented Apr 29, 2024

https://progress.opensuse.org/issues/159546

@rfan1 rfan1 requested review from jlausuch and removed request for ricardobranco777 and mloviska April 29, 2024 07:16
@rfan1 rfan1 added the qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them label Apr 29, 2024
@rfan1 rfan1 force-pushed the slem_nm_s390x branch 2 times, most recently from 59463be to b0b91d6 Compare April 29, 2024 07:25
@rfan1 rfan1 changed the title Fix network configuration on slem for s390x NM test Fix network configuration on s390x for slem NM test Apr 29, 2024
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions, LGTM.

tests/microos/networkmanager.pm Outdated Show resolved Hide resolved
tests/microos/networkmanager.pm Outdated Show resolved Hide resolved
@rfan1 rfan1 force-pushed the slem_nm_s390x branch 3 times, most recently from 0a6158f to 38332cc Compare April 29, 2024 10:24
@rfan1 rfan1 added the WIP Work in progress label Apr 29, 2024
@rfan1 rfan1 force-pushed the slem_nm_s390x branch 5 times, most recently from 8c17d72 to d76cf59 Compare April 29, 2024 13:27
@rfan1 rfan1 merged commit 54488da into os-autoinst:master Apr 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them WIP Work in progress
Projects
None yet
4 participants