Unregister from SCC after worker finishes #1923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how did you test? Please describe the test procedure in the commit message |
okurz
requested changes
Oct 9, 2016
| # notice and this notice are preserved. This file is offered as-is, | ||
| # without any warranty. | ||
|
|
||
| #use base "basetest"; |
| sub setup_unregister_hook { | ||
| # Get file without switching console | ||
| # console("testapi_console")->type_string("stringstring"); | ||
| # my $creds = console("install-shell")->script_output("cut -d= -f2 /etc/zypp/credentials.d/SCCcredentials"); |
kravciak
force-pushed
the
scc
branch
4 times, most recently
from
701e761
to
84e6f13
Compare
We need to consider canceled & failed jobs, so de-registration must be
performed from worker. It needs username & password that are generated
during registration and exported into SCC_DEREGISTER variable.
Worker unregister from scc using by calling SCC url with:
DELETE /connect/systems
There is a short window between system registration and
set_var("SCC_DEREGISTER"), when system would not unregister.
Tested by:
- Following logs in /var/lib/openqa/pool/<worker>/autoinst-log.txt
- By canceling jobs before/during/after registration or finishing them
- Checking that SCC keys are removed from scc.suse.com (Alpha Keys)
|
First of all: this change is not merged/deployd - so it didn't break anything yet. But I guess you're right, it will. So we need to treat scc registrations like assets - and unregister the least used used. I.e. do parts of what Martin did and upload the keys used in a job. But don't unregister immediately, but from a background job on the webui |
|
Thanks for noticing, we missed this when talking to qam/slenkins people about breaking stuff with this approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://progress.opensuse.org/issues/11518
We need to consider canceled & failed jobs, so de-registration must be
performed from worker. It needs username & password that are generated
during registration and exported into SCC_DEREGISTER variable.
Worker unregister from scc using by calling SCC url with:
DELETE /connect/systems
There is a short window between system registration and set_var("SCC_DEREGISTER"), when system would not unregister.
Tested by:
After successful job:
SLES: http://dhcp91.suse.cz/tests/2772
JeOS: http://dhcp91.suse.cz/tests/2771
Job canceled:
QAM SLES-12-GA: http://dhcp91.suse.cz/tests/2778
SLES: http://dhcp91.suse.cz/tests/2774
JeOS: http://dhcp91.suse.cz/tests/2773