Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add down key in selecting patterns when pcm added #19245

Closed
wants to merge 1 commit into from
Closed

Add down key in selecting patterns when pcm added #19245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/y2_installbase.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ patterns.

sub select_not_install_any_pattern {
my ($self) = @_;

send_key_until_needlematch('minimal-system', 'down') if check_var_array('SCC_ADDONS', 'pcm');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iterating the patterns is complicated process, there is a dedicated module for that, really old but sort of reliable, as old as the YaST Ui in that part, I would not take risk here iterating anything with something new, this code that you are updating had the goal to not iterate and rely on what was in the screen. The iteration should be visible as part of the test anyway, at least that was the idea how it was designed.
The other two options would be better:
(1) use select_patterns for all 3 arch. where this test suite is running including the pcm
(2) as it is a minimal scenario we don't need the pcm, remove it from setting and that would fix as well (I think it is more simple and Lemon use that solution already).

# Ensure mouse on certain pattern then right click
assert_and_click("minimal-system", button => 'right');
assert_screen 'selection-menu';
Expand Down