Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt automation in Yam scope to not check the beta popup #19249

Merged
merged 1 commit into from
May 7, 2024

Conversation

tinawang123
Copy link
Contributor

Adapt automation in Yam scope to not check the beta popup

@tinawang123 tinawang123 changed the title Adapt automation in Yam scope to not check the beta popup [WIP]Adapt automation in Yam scope to not check the beta popup May 7, 2024
@jknphy jknphy requested review from rakoenig and lemon-suse May 7, 2024 08:44
@tinawang123 tinawang123 changed the title [WIP]Adapt automation in Yam scope to not check the beta popup Adapt automation in Yam scope to not check the beta popup May 7, 2024
@lemon-suse
Copy link
Contributor

In general, LGTM. Just feel we'd better find a better way to fix this so that we don't need add/remove this module in the future. :)

@jknphy
Copy link
Contributor

jknphy commented May 7, 2024

In general, LGTM. Just feel we'd better find a better way to fix this so that we don't need add/remove this module in the future. :)

we actually prefer to add it so we can really be sure when the product have it or not, in the future we will only change it in one single place. But I'm also not 100 % sure if worth it, probably is the single case where we could be more flexible... Could you file a ticket title for example "Make conditional the beta popup expectation in a way that is a clear exception in design". We can check it later when we have single place of change to see how it could look technically.

@jknphy jknphy merged commit 78aac12 into os-autoinst:master May 7, 2024
10 checks passed
@lemon-suse
Copy link
Contributor

In general, LGTM. Just feel we'd better find a better way to fix this so that we don't need add/remove this module in the future. :)

we actually prefer to add it so we can really be sure when the product have it or not, in the future we will only change it in one single place. But I'm also not 100 % sure if worth it, probably is the single case where we could be more flexible... Could you file a ticket title for example "Make conditional the beta popup expectation in a way that is a clear exception in design". We can check it later when we have single place of change to see how it could look technically.

Created the ticket https://progress.opensuse.org/issues/160056

@tinawang123 tinawang123 deleted the beta branch May 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants