Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent password from expiring #19259

Conversation

pablo-herranz
Copy link
Contributor

@pablo-herranz pablo-herranz commented May 8, 2024

Although the configuration is being done in the unattend file, is not working properly. As a workaround I've decided to extract it to the firstboot.

image

@pablo-herranz pablo-herranz added the WIP Work in progress label May 8, 2024

This comment was marked as off-topic.

@pablo-herranz pablo-herranz force-pushed the poo160035_Windows-password-expired branch from 7b640f5 to 24c93ef Compare May 8, 2024 07:23
Although the configuration is being done in the unattend file, is not working properly. As a workaround I've decided to extract it to the firstboot.
@pablo-herranz pablo-herranz force-pushed the poo160035_Windows-password-expired branch from 24c93ef to d0e73a7 Compare May 8, 2024 08:15
@pablo-herranz pablo-herranz added RFC Request for Comments and removed WIP Work in progress labels May 8, 2024
@pablo-herranz pablo-herranz marked this pull request as ready for review May 8, 2024 13:24
Copy link
Contributor

@ricardobranco777 ricardobranco777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must require a lot of patience... LGTM!

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only does it work now, it makes the existing code also better.

+2 LOC -26 LOC - I love PR that are removing more code than adding. Nicely done!

@pablo-herranz pablo-herranz merged commit 70fe294 into os-autoinst:master May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for Comments
Projects
None yet
3 participants