Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/serial_terminal.pm: Handle serial tty prompt with util-linux 2.40 #19268

Closed
wants to merge 1 commit into from

Conversation

Vogtinator
Copy link
Member

@Vogtinator Vogtinator commented May 8, 2024

Instead of ESC ( B it uses ASCII 0Fh (SI, Shift In).

Instead of ESC ( B it uses ASCII 0Fh (SI, Shift In).
Copy link

github-actions bot commented May 8, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@Vogtinator Vogtinator marked this pull request as ready for review May 8, 2024 14:36
@Vogtinator
Copy link
Member Author

It's possible that util-linux 2.40.1 reverts back to the previous prompt, so let's wait for that

@Vogtinator Vogtinator marked this pull request as draft May 8, 2024 14:56
@Vogtinator
Copy link
Member Author

It's possible that util-linux 2.40.1 reverts back to the previous prompt, so let's wait for that

And that's exactly what happened: https://openqa.opensuse.org/tests/4173750#live

@Vogtinator Vogtinator closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant