Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip loading kontact and khelpcenter on unsupported architecture #19297

Merged
merged 1 commit into from
May 16, 2024

Conversation

cedvid
Copy link
Contributor

@cedvid cedvid commented May 14, 2024

Copy link

github-actions bot commented May 14, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

Files matching t/data/test_schedule.out:

  • Ensure openSUSE/SLE release managers are ok with the change in staging schedule

This is an automatically generated QA checklist based on modified files.

@cedvid cedvid marked this pull request as ready for review May 14, 2024 11:21
@cedvid cedvid added Ready Ready for review qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them labels May 14, 2024
@foursixnine
Copy link
Member

@cedvid, I think you need to check the default schedule but in general it shouldn´t be black magic in the end, and I think that the changes are OK, but I'm not entirely sure.

@cedvid
Copy link
Contributor Author

cedvid commented May 15, 2024

@cedvid, I think you need to check the default schedule but in general it shouldn´t be black magic in the end, and I think that the changes are OK, but I'm not entirely sure.

What do you mean by default schedule? I am not sure I understand.

@foursixnine
Copy link
Member

@cedvid, I think you need to check the default schedule but in general it shouldn´t be black magic in the end, and I think that the changes are OK, but I'm not entirely sure.

What do you mean by default schedule? I am not sure I understand.

so a default schedule is kind of whatever runs from main.pm, i.e try cloning a gnome test, and see if these modules are not shown

@cedvid
Copy link
Contributor Author

cedvid commented May 15, 2024

@cedvid, I think you need to check the default schedule but in general it shouldn´t be black magic in the end, and I think that the changes are OK, but I'm not entirely sure.

What do you mean by default schedule? I am not sure I understand.

so a default schedule is kind of whatever runs from main.pm, i.e try cloning a gnome test, and see if these modules are not shown

but it wouldn't show for gnome anyway since the modules are only loaded if (kdestep_is_applicable()). Or am I misunderstanding your comment?

lib/main_common.pm Outdated Show resolved Hide resolved
@foursixnine
Copy link
Member

@cedvid to address @okurz

Or is the default scenario from a non-default architecture? Probably yes so how about excluding unsupported architectures instead of only enabling on selected architectures?

Lets make a follow, lets make a ticket to have isotovideo default scenarios for all 4 architectures, but excluding 32bits which is the root cause here.

@foursixnine foursixnine merged commit 8341ef5 into os-autoinst:master May 16, 2024
10 checks passed
@cedvid cedvid deleted the kontact-arch branch May 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qe-core Tag used to filter PR's created by QE-Core's members or are assigned to them Ready Ready for review
Projects
None yet
3 participants