Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers: Minimize dependency on registry mirror #19383

Merged
merged 2 commits into from
May 27, 2024

Conversation

ricardobranco777
Copy link
Contributor

@ricardobranco777 ricardobranco777 commented May 24, 2024

Minimize dependency on registry mirror. Some uses of alpine can be perfectly done by smaller busybox image from OBS. Same with httpd shipped by openSUSE.

Copy link
Member

@pdostal pdostal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

Copy link
Contributor

@grisu48 grisu48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As Ricardo stated, this is only part of the solution for https://progress.opensuse.org/issues/160823.

Also VRs are missing, please provide.

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@ricardobranco777 ricardobranco777 merged commit dcc109b into os-autoinst:master May 27, 2024
10 checks passed
@ricardobranco777 ricardobranco777 deleted the skipothers branch May 27, 2024 10:23
@nilxam
Copy link
Member

nilxam commented May 28, 2024

this break podman/docker container test with Test died: Undefined subroutine &containers::common::registry_url called at opensuse/lib/containers/common.pm line 196.

see https://openqa.opensuse.org/tests/4225757#step/docker/77 and https://openqa.opensuse.org/tests/4226074#step/podman/47

@ggardet
Copy link
Collaborator

ggardet commented May 28, 2024

this break podman/docker container test with Test died: Undefined subroutine &containers::common::registry_url called at opensuse/lib/containers/common.pm line 196.

see https://openqa.opensuse.org/tests/4225757#step/docker/77 and https://openqa.opensuse.org/tests/4226074#step/podman/47

Yes, on Tumbleweed as well.

@ana
Copy link
Contributor

ana commented May 28, 2024

@ricardobranco777 Same issue than reported by @nilxam and @ggardet

This is blocking Tumbleweed staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
7 participants