Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wsl patterns from autoyast profiles for support images #19586

Merged

Conversation

chcao
Copy link
Contributor

@chcao chcao commented Jun 21, 2024

Remove wsl_base, wsl_gui and wsl_systemd patterns from autoyast profiles for support images. Based on bsc#1226314, we don't set wsl environment in migration testing, so we don't add these patterns.

@chcao chcao force-pushed the remove_wsl_patterns_from_ay_profile branch from 157e26e to fafe531 Compare June 21, 2024 13:52
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

Remove wsl_base, wsl_gui and wsl_systemd patterns from autoyast
profiles for support images. Based on bsc#1226314, we don't set wsl
environment in migration testing, so we don't add these patterns.
@chcao chcao changed the title [WIP] Remove wsl patterns from autoyast profiles for support images Remove wsl patterns from autoyast profiles for support images Jun 24, 2024
@chcao chcao added the qe-yam label Jun 24, 2024
@chcao chcao requested a review from lemon-suse June 24, 2024 05:55
@jknphy jknphy merged commit 56e355f into os-autoinst:master Jun 24, 2024
10 checks passed
@lemon-suse
Copy link
Contributor

LGTM. For the test of WSL patterns, it is better to have a document to describe which pattern is supported and which pattern is not supported and why for all patterns or default patterns test. No official document means no limit for such test scenario or use case : install WSL patterns for installation or migration test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants