Get rid of REPO_SLES_DEBUG, visual glitches fixes #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Oct 20, 2016
| @@ -17,49 +17,25 @@ use utils; | |||
|
|
|||
| sub install_kernel_debuginfo { | |||
| # kernel debug symbols are huge, this can take a while | |||
| assert_script_run 'zypper ref; zypper -n -v in kernel-default-base-debuginfo kernel-default-debuginfo', 1200; | |||
| script_run 'rpmquery -a kernel-default*'; | |||
There was a problem hiding this comment.
why is this command allowed to fail and how do you use it? is it just for debugging? It should help to also call this one with assert_script_run because if it fails, something is clearly wrong, isn't it?
added 2 commits
October 21, 2016 09:24
On PPC64LE, at least, the test which runs before `crash`, creates post-mortem screen distortion. Previously we tried to clear the screen before needle matching, but a more robust solution is to restart the system and then do the matching. To achieve that code was reshuffled here and there.
REPO_SLES_DEBUG variable formerly provided by `rsync.pl` script is now not available. The information required - a directory on FTP server which holds kernel debuginfos - is now get from REPO_0 variable and couple of string transformations on it's content.
mnowaksuse
force-pushed
the
crash_wo_REPO_SLES_DEBUG2
branch
from
9ac3466
to
e221d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of
REPO_SLES_DEBUGas it's not provided by rsync.plthe information can be extracted from
REPO_0var as well.Also removing 'screen-cleaning' because of previous test's
esses' random writes to TTY; reboot will rule them out.
Verification run: http://assam.suse.cz/tests/4057.