Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup, make test case more robust when gv is not available #2139

Merged
merged 1 commit into from
Nov 18, 2016
Merged

Fix cleanup, make test case more robust when gv is not available #2139

merged 1 commit into from
Nov 18, 2016

Conversation

eisfuchs-de
Copy link
Contributor

Summary:

  • Fix cleanup of ghostscript helper script
  • Make test case more robust when gv is not available, skip the gv test

Sample:
Cleanup: http://froh.qam.suse.de/tests/86
gv: http://froh.qam.suse.de/tests/87

@coolo
Copy link
Contributor

coolo commented Nov 18, 2016

looks good, now tools/tidy and commit --amend -a and push -f :)

@okurz
Copy link
Member

okurz commented Nov 18, 2016

The commit message could have a bit more details, e.g. what issue is fixed, why this needs to change, to which versions of which product it applies, link to a bug or a fate entry, the choices you made, etc. Also see http://chris.beams.io/posts/git-commit/ as a helpful guide how to write good commit messages.

What you put into the description of the pull request could also be in the commit message details.

I can recommend the tool "hub" (zypper in rubygem-hub) for easier PR creation. Also, I myself use a script to create a PR with proper description for these simple one-commit PRs:

$ cat $(which git-pr-last )
#!/bin/sh -e
target="${target:-"$USER"}"
git push $target && git show --no-patch --format=%B | hub pull-request -F -

@eisfuchs-de
Copy link
Contributor Author

Thanks for the suggestions and the links! I'll look at these and hopefully get better at this with time!

@coolo coolo merged commit 5dc1cda into os-autoinst:master Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants