Explicitly catch pkcon proceed prompt hit again as error #2210
Conversation
| @@ -134,7 +134,8 @@ sub ensure_installed { | |||
| testapi::assert_script_sudo("chown $testapi::username /dev/$testapi::serialdev"); | |||
| my $retries = 5; # arbitrary | |||
| $self->script_run("for i in {1..$retries} ; do pkcon install $pkglist && break ; done ; RET=\$?; echo \"\n pkcon finished\n\"; echo \"pkcon-\${RET}-\" > /dev/$testapi::serialdev", 0); | |||
| my @tags = qw/Policykit Policykit-behind-window pkcon-proceed-prompt pkcon-finished/; | |||
| my @tags = qw/Policykit Policykit-behind-window pkcon-proceed-prompt pkcon-finished/; | |||
There was a problem hiding this comment.
I thought we are using brackets now? :-)
There was a problem hiding this comment.
not yet, only after my after PR is merged. I don't like to change the style on single lines when the focus should be on something else, in this case that I changed other parts of the code.
There was a problem hiding this comment.
and I would like code touched to follow the style guide
Local verification run: http://lord.arch/tests/5474 Related progress issue: https://progress.opensuse.org/issues/15410
okurz
force-pushed
the
fix/pkcon_proceed_hit_again
branch
from
cf448c9
to
c83abce
Compare
That test seems invalid: as the live image has no root password, you won't get a polkit auth dialog to ask for permission to install https://openqa.opensuse.org/tests/321497#step/kate/9 Does not look like something would have gone wrong - except the sequence of seeing the old prompt again (still) |
|
prep_pidgin.pm use ensure_installed('pidgin') to install the pidgin, and it failed |
|
on it |
|
fixed by #2224 |
Local verification run: http://lord.arch/tests/5474
Related progress issue: https://progress.opensuse.org/issues/15410