Enable fail while using pipelining in bash #2217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any commands fail in bash pipeline
|
@okurz please review |
|
reference a successful test run please |
|
Please provide a link or screenshot to a local verification run. |
|
one screenshot is very little in this context :) |
|
@coolo agree with you , what will be enough on your opinion ? one full test run ? few tests ? some certain test ? |
|
One full (i.e. more than 50 test modules) would do |
|
@coolo here one full run http://kimball.arch.suse.de/tests/31#, there are some failures but they are not related to this change for sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If any commands fail in bash pipeline