Increase timeout for package install #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please reference at least a failing test case which should be fixed by this one. Also it would be if you state why this bumping up the timeout should be ok. |
|
I'm not sure this is needed, latest builds are just fine. IMO the test failed because of performance issue on worker. Did you tried to restart the job? |
|
@dgutu-suse restart of job looks like run away from a problem , we should have test which tolerant to performance issues on worker . But on other side I agree with you that increasing timeout is also not the best solution , this is why in parallel to this PR I also create a progress issue to take a look on this problem deeper (not during test review :) ) - https://progress.opensuse.org/issues/15614. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@okurz please take a look