Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect linuxrc core dumps and logs if available #2291

Merged
merged 4 commits into from
Jan 12, 2017

Conversation

okurz
Copy link
Member

@okurz okurz commented Jan 9, 2017

linuxrc core dumps have been added after a discussion in
https://bugzilla.suse.com/show_bug.cgi?id=1010505#c9 as described on
https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore
If they are available the should be collected to the serial log and can be
decoded using uudecode so that we can debug problems during bootup of the
installer system, e.g. as happened in bsc#1010505.

Local verification runs:

Related progress issue: https://progress.opensuse.org/issues/13896

Now specifying the video mode regardless of the architecture as we assume xga
anyway in all cases.
linuxrc core dumps have been added after a discussion in
https://bugzilla.suse.com/show_bug.cgi?id=1010505#c9 as described on
https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore
If they are available the should be collected to the serial log and can be
decoded using uudecode so that we can debug problems during bootup of the
installer system, e.g. as happened in bsc#1010505.

Local verification runs:
* TW uefi: http://lord.arch/tests/5521
* SLE: http://lord.arch/tests/5523

Related progress issue: https://progress.opensuse.org/issues/13896
@okurz okurz changed the title Collect linuxrc core dumps if available Collect linuxrc core dumps and logs if available Jan 9, 2017
@okurz okurz force-pushed the feature/linuxrc_core_dumps branch from d36b6b0 to bf386d1 Compare January 9, 2017 13:22
@sysrich
Copy link
Member

sysrich commented Jan 11, 2017

Can you explain how cd467fc and d372392 are related to this PR? The relevance is not obvious by reading the PR description

@okurz
Copy link
Member Author

okurz commented Jan 11, 2017

both commits are refactorings which are part of the change and closely related. I prefer to have separate commits but bundle them in the same PR so that diffs within commits are easier to follow

@okurz okurz removed the question label Jan 11, 2017
Copy link
Contributor

@Soulofdestiny Soulofdestiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okurz okurz merged commit e77fc96 into os-autoinst:master Jan 12, 2017
@okurz okurz deleted the feature/linuxrc_core_dumps branch January 12, 2017 11:37

# Enable linuxrc core dumps https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore
type_string_very_slow "linuxrc.core=$serialdev ";

assert_screen "inst-consolesettingstyped", 30;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this order is wrong. It should asserting what we typed into consolesettingstyped - and only then type more.

Because: https://openqa.opensuse.org/tests/333365#step/bootloader/6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants