-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect linuxrc core dumps and logs if available #2291
Conversation
Now specifying the video mode regardless of the architecture as we assume xga anyway in all cases.
linuxrc core dumps have been added after a discussion in https://bugzilla.suse.com/show_bug.cgi?id=1010505#c9 as described on https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore If they are available the should be collected to the serial log and can be decoded using uudecode so that we can debug problems during bootup of the installer system, e.g. as happened in bsc#1010505. Local verification runs: * TW uefi: http://lord.arch/tests/5521 * SLE: http://lord.arch/tests/5523 Related progress issue: https://progress.opensuse.org/issues/13896
d36b6b0
to
bf386d1
Compare
both commits are refactorings which are part of the change and closely related. I prefer to have separate commits but bundle them in the same PR so that diffs within commits are easier to follow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
# Enable linuxrc core dumps https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore | ||
type_string_very_slow "linuxrc.core=$serialdev "; | ||
|
||
assert_screen "inst-consolesettingstyped", 30; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this order is wrong. It should asserting what we typed into consolesettingstyped - and only then type more.
Because: https://openqa.opensuse.org/tests/333365#step/bootloader/6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linuxrc core dumps have been added after a discussion in
https://bugzilla.suse.com/show_bug.cgi?id=1010505#c9 as described on
https://en.opensuse.org/SDB:Linuxrc#p_linuxrccore
If they are available the should be collected to the serial log and can be
decoded using uudecode so that we can debug problems during bootup of the
installer system, e.g. as happened in bsc#1010505.
Local verification runs:
Related progress issue: https://progress.opensuse.org/issues/13896