Press return to select user with LXDE 42.1 #2303
Conversation
| @@ -23,7 +23,7 @@ sub handle_login { | |||
| if (get_var('DM_NEEDS_USERNAME')) { | |||
| type_string "$username\n"; | |||
| } | |||
| if (check_var('DESKTOP', 'gnome')) { | |||
| if (check_var('DESKTOP', 'gnome') || (check_var('DESKTOP', 'lxde') && check_var('VERSION', '42.1'))) { | |||
There was a problem hiding this comment.
I suggest to not check for explicit versions but use a version comparison.
There was a problem hiding this comment.
what do you mean with version comparison ?
this is here only because this specific DM on lxde 42.1 does need to select user, such case is not in version before or after (It is maybe silly, but it is so)
There was a problem hiding this comment.
ok, if it is really that silly than just keep it :-)
| @@ -23,7 +23,7 @@ sub handle_login { | |||
| if (get_var('DM_NEEDS_USERNAME')) { | |||
| type_string "$username\n"; | |||
| } | |||
| if (check_var('DESKTOP', 'gnome')) { | |||
| if (check_var('DESKTOP', 'gnome') || (check_var('DESKTOP', 'lxde') && check_var('VERSION', '42.1'))) { | |||
| # In GNOME/gdm, we do not have to enter a username, but we have to select it | |||
There was a problem hiding this comment.
I'm pretty sure there are gnome versions where it is true, DM is always changing, new theme or behavior, and will continue
There was a problem hiding this comment.
No, I mean the comment only refers to gnome but not to lxde but you are checking for this, too
There was a problem hiding this comment.
I will update in opened PR
|
https://progress.opensuse.org/issues/15996 -> still not working |
fail
test