Fix zypper_lifecycle test #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bsc#1028247, poo#17566 - specify the condition when a link to www.suse.com/lifecycle should appear - handle allowed return values, do not rely on return value, check also text output - remove duplicated test
|
LGTM, waiting for checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should appear
check also text output
Test run:
http://sleposbuilder4.suse.cz/tests/3104#step/zypper_lifecycle/5
The test ran with unchanged zypper-lifecycle package. The issue from bsc#1028247 comment 1 seems to be harmless, it prints the error, but the rest of output and exit value is as expected..