-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lock package feature for online migration #2533
Conversation
LGTM |
@@ -592,6 +592,9 @@ sub load_consoletests() { | |||
loadtest "rt/kmp_modules"; | |||
} | |||
loadtest "console/consoletest_setup"; | |||
if (get_var("LOCK_PACKAGE")) { | |||
loadtest "console/check_locked_package"; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about openSUSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
openSUSE only has offline migration, I will consider to include it when adding sle offline migration.
On Monday, 13 March 2017 01:46:09 CET Wei Jiang wrote:
mitiao commented on this pull request.
> @@ -592,6 +592,9 @@ sub load_consoletests() {
loadtest "rt/kmp_modules";
}
loadtest "console/consoletest_setup";
+ if (get_var("LOCK_PACKAGE")) {
+ loadtest "console/check_locked_package";
+ }
openSUSE only has offline migration, I will consider to include it when
adding sle offline migration.
openSUSE has online upgrades so I guess it still applies.
|
tests/console/lock_package.pm
Outdated
# without any warranty. | ||
|
||
# Summary: lock package test mainly used for migration testsuite | ||
# Maintainer: Wei Jiang <wjiang@suse.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a reference to any fate# or bsc# or at least poo#?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add poo# to summary
Could you show me the online updates for openSUSE? Since I don't really work on that :) |
sure. Take a look on https://openqa.opensuse.org/tests/overview?distri=opensuse&version=Tumbleweed&groupid=1 for openSUSE Tumbleweed. There are tests called "update…" which are the "offline upgrade/migration" tests and all the "zdup" variants are "online upgrade" tests. |
Well, it is called offline migration in https://openqa.suse.de/tests/overview?distri=sle&version=12-SP3&build=0271&groupid=65 for SLE :) |
cool, but did you test it for openSUSE as well? your verification runs seem to be SLE only |
@okurz do we really require validation runs for every codebase? SLE 12, SLE 12 SP1, SLE 12 SP1 LTSS, SLE 12 SP2, SLE 12 SP2 LTSS, openSUSE Leap 42.1, Leap 42.2, and Tumbleweed? |
@sysrich and what about SLED? ;) |
@sysrich no, not for all codebases. But I assume you agree that openSUSE online upgrade can be quite different from SLE? If it should be "Tumbleweed first" then I assume it makes sense to test it for openSUSE |
Verified run for Tumbleweed: |
See https://progress.opensuse.org/issues/17206
This is first version of locking package, and only tested during online migration.
Would be added for offline migration later.
Verified runs:
http://147.2.207.208/tests/429
http://147.2.207.208/tests/431