Extension for qam-minimal tests (poo#17412) #2563
Conversation
mimi1vx
force-pushed
the
extend_qam-minimal
branch
from
ab85ca9
to
c55b9ed
Compare
| my $patch_info = shift; | ||
| my $pattern = qr/\s+(.+)(?!\.src)\..*\s<\s.*/; | ||
|
|
||
| # loop over packages in patchinfo and try instalation |
| sub run { | ||
| my ($self) = @_; | ||
| my $patch = get_var('INCIDENT_PATCH'); |
There was a problem hiding this comment.
before declaring this to the patch variable, it would be a good practice to make sure that the env variable INCIDENT_PATCH exists and it's not empty. e.g.
# Check if INCIDENT_PATCH variable exists and has a non-empty value
die "openQA Error -> Cannot find the maintenance incident patch" unless get_var('INCIDENT_PATCH');
There was a problem hiding this comment.
this, isnt needed , it always defined by test settings. In reality we can remove INCINDENT_REPO test
There was a problem hiding this comment.
If they are not needed, then for the sake of consistency I would suggest to treat all the settings in the same way. So, either remove the check for both, or add it for both ;)
There was a problem hiding this comment.
In general, keep the case in mind that the variable is undefined. get_var can also take an optional default value, e.g. get_var('PATCH', 'foo'). If you rely on the variable being defined, use get_required_var().
mimi1vx
force-pushed
the
extend_qam-minimal
branch
from
c55b9ed
to
e03c24e
Compare
If test is qam-minimal mark test softfailed wheen patch isn't needed in minimal pattern. And skip patch installation. For qam-minimal-full test records info, if patch isn't needed for minimal pattern. If patch isn't applied in install_patterns step installs packages mentioned in patchinfo.
mimi1vx
force-pushed
the
extend_qam-minimal
branch
from
e03c24e
to
e5dca02
Compare
|
Ping? |
If test is qam-minimal mark test softfailed wheen patch isn't needed in
minimal pattern. And skip patch installation.
For qam-minimal-full test records info, if patch isn't needed for
minimal pattern. If patch isn't applied in install_patterns step installs
packages mentioned in patchinfo.
http://argus.suse.cz/tests/186
http://argus.suse.cz/tests/185
http://argus.suse.cz/tests/187