Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for screen change in setraidlevel poo#18444 #2752

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

thehejik
Copy link
Contributor

When selecting wanted RAID level some keystrokes (eg. Tab) are ignored on xgene2 and mustang3 workers (seattle6 works fine) and then the test is failing, see https://openqa.suse.de/tests/881471#step/partitioning_raid/130

This commit is adding a wait between keystrokes and hopefully will fix that issue - it works correctly on x86_64 http://dhcp209.suse.cz/tests/4084 but I didn't test on aarch64.

Unfortunately I don't find a better solution for it because wait_screen_change() will probably not match flashing cursor which is the only change in the screen.

@thehejik thehejik changed the title Add wait for send_key() in setraidlevel() poo#18444 Wait for keypress in setraidlevel poo#18444 Apr 18, 2017
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the argument to send_key is boolean. 2 is very confusing as value for "true" if this is what you intended. We want to avoid the use of wait_idle so I am objecting this change. But if you want to help you are welcome to take over os-autoinst/os-autoinst#704

@thehejik
Copy link
Contributor Author

thehejik commented Apr 18, 2017

Ah, good to know. I thought that the argument is in seconds and not a Boolean. As I wrote before I cannot use wait_screen_change in this case (the only change is flashing cursor). Any idea?

@okurz
Copy link
Member

okurz commented Apr 18, 2017

Any idea?

yes, you wrote "wait_screen_change() will probably not match" so please check if this is really true ;-) As an alternative use wait_still_screen to force some waiting or even assert_screen <tag>, no_wait => 1

@thehejik thehejik force-pushed the thehejik/setraidlevel_timeout branch from 644d23f to 34ad03b Compare April 19, 2017 13:59
@thehejik thehejik changed the title Wait for keypress in setraidlevel poo#18444 Wait for screen change in setraidlevel poo#18444 Apr 19, 2017
@thehejik
Copy link
Contributor Author

Now the test is using wait_screen_change in setraidlevel() and it works at least on x86_64 \o/

@okurz okurz merged commit 1a60690 into os-autoinst:master Apr 19, 2017
@thehejik thehejik deleted the thehejik/setraidlevel_timeout branch April 19, 2017 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants