Add support to check LTSS repos #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Apr 27, 2017
lib/utils.pm
Outdated
| @@ -588,6 +588,9 @@ sub validatelr { | |||
| $product = 'SLE-Module-Web-Scripting'; | |||
| $version = '12'; | |||
| } | |||
| if ($product =~ /LTSS/) { | |||
| $version = ''; | |||
There was a problem hiding this comment.
can you add a comment why this should be a good idea?
lib/utils.pm
Outdated
| @@ -743,6 +752,10 @@ sub validate_repos_sle { | |||
| for my $product_channel ("Pool", "Updates", "Debuginfo-Pool", "Debuginfo-Updates", "Source-Pool") { | |||
| # Toolchain module doesn't have Source-Pool channel | |||
| next if (($scc_product eq 'SLE-TCM') && ($product_channel eq 'Source-Pool')); | |||
| # LTSS doesn't have Pool, Debuginfo and Sourcer-Pool channels | |||
lib/utils.pm
Outdated
| # LTSS doesn't have Pool, Debuginfo and Sourcer-Pool channels | ||
| next if (($scc_product =~ /LTSS/) && ($product_channel eq 'Pool')); | ||
| next if (($scc_product =~ /LTSS/) && ($product_channel eq 'Debuginfo-Pool')); | ||
| next if (($scc_product =~ /LTSS/) && ($product_channel eq 'Source-Pool')); |
There was a problem hiding this comment.
how about
next if $scc_product =~ /LTSS/ and $product_channel =~ /(|Debuginfo-|Source-)Pool/;
mitiao
force-pushed
the
ltss_repos_check
branch
from
218c8b6
to
ae708f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verified run:
http://147.2.207.208/tests/491#step/repos_check/16