Fix for poo#18860 #2820
Merged
Fix for poo#18860 #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://argus.suse.cz/tests/779#step/shutdown/1 - SLE12 VIRTIO_CONSOLE=0 |
okurz
reviewed
Apr 29, 2017
tests/shutdown/shutdown.pm
Outdated
|
|
||
| sub run { | ||
|
|
||
| select_console('root-console'); | ||
| if (get_var('DROP_PERSISTENT_NET_RULES')) { | ||
| type_string "rm -f /etc/udev/rules.d/70-persistent-net.rules\n"; | ||
| } | ||
|
|
||
| unless (sle_version_at_least('12-SP1') && !check_var('VIRTIO_CONSOLE', 1)) { |
There was a problem hiding this comment.
that unless paired with !check_var is really hard to follow. Can you use if?
Start and enable serial-getty@hvc0 on SLE12 and SLE12SP1 if is VIRTIO_CONSOLE set to 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start and enable serial-getty@hvc0 on SLE12 and SLE12SP1 if is
VIRTIO_CONSOLE set to 1