kdump test #2904

yxususe · 2017-05-17T13:44:21Z

No description provided.

okurz · 2017-05-17T15:17:31Z

looks nice so far. But I don't fully understand what each test module is ensuring now. I recommend you put a full header into tests/toolchain/kdump.pm with a summary of what the module should test. Also we should avoid to fill up lib/utils.pm more. I suggest to actually put that helper function which you extracted - good job on that by the way - into a baseclass of both test modules.

@mnowaksuse your review would be appreciated.

foursixnine · 2017-05-17T15:32:43Z

lib/main_common.pm

@@ -501,12 +501,13 @@ sub load_extra_tests() {
            # sysauth test scenarios run in the console
            loadtest "sysauth/sssd";
        }
-        # finished console test and back to desktop
-        loadtest "console/consoletest_finish";
        # kdump is not supported on aarch64, see BSC#990418
        if (!check_var('ARCH', 'aarch64')) {


I would still enable them even for aarch64. Also the bug reference is wrong bsc#1037407. BSC#990418 is already closed.

Hi, consoletest_finish is moved to the end. Because often it couldn't finish, and then the following tests will be skipped. Thanks for the hint about bug reference, I'll have a look.

yxususe · 2017-05-18T07:39:50Z

Hi Oliver, kdump and crash test have the same set up steps, thus to avoid code duplication, the set up steps are extracted. Theoretically We could still merge them, because crash is based on kdump anyway. crash will do one more work than kdump, which is to analyse vmcore file generated by kdump. The problem now is that kdump is not stable, it behaves randomly on if it can be enabled or not. Besides that, the tests already function as expected on openSUSE Leap. At the moment I'm testing them on SLES and Tumbleweed, and it still needs to be improved. Thanks for your suggestions, I will try it out.

yxususe · 2017-05-18T13:39:27Z

I did an update of my WIP.

yxususe · 2017-05-22T09:48:59Z

I did an update of my WIP. Could you also have a look? @michalnowak mnowak

mnowaksuse · 2017-05-22T09:54:00Z

@yxususe I will. Note that there's whitespace issue in Travis.

yxususe · 2017-05-22T10:09:06Z

Thanks @michalnowak, the whitespace issue is fixed now.

mnowaksuse · 2017-05-22T10:27:58Z

lib/kdump_utils.pm

    script_run 'zypper ref';
-    zypper_call('-v in $(rpmquery kernel-default | sed "s/kernel-default/kernel-default-debuginfo/")');


Can you keep versioned installation of kernel-default-debuginfo package, please? We used to have problems with wrong kernel-default-debuginfo versions in SUT's repositories, which led to weird issues with crash'es infrastructure.

mnowaksuse · 2017-05-22T10:29:03Z

lib/kdump_utils.pm

    # make sure kdump is enabled after reboot
-    validate_script_output "yast2 kdump show 2>&1", sub { m/Kdump is enabled/ }, 90;
+    #validate_script_output "yast2 kdump show 2>&1", sub { m/Kdump is enabled/ }, 90;


Dead "code". Remove it, perhaps.

not perhaps, please remove :-)

mnowaksuse · 2017-05-22T10:31:18Z

lib/main_common.pm

-        # finished console test and back to desktop
-        loadtest "console/consoletest_finish";
-        # kdump is not supported on aarch64, see BSC#990418
+        # kdump is not supported on aarch64, see BSC#1037407


Make BSC lowercase, as it's the one we usually go.

okurz

please see inline comments and also provide verification runs for openSUSE and SLE.

okurz · 2017-05-22T10:30:13Z

lib/kdump_utils.pm

@@ -1,32 +1,27 @@
 # SUSE's openQA tests
 #
-# Copyright © 2016-2017 SUSE LLC
+# Copyright © 2017 SUSE LLC


please keep old as it refers to the content, not the file

okurz · 2017-05-22T10:30:55Z

lib/kdump_utils.pm

    # make sure kdump is enabled after reboot
-    validate_script_output "yast2 kdump show 2>&1", sub { m/Kdump is enabled/ }, 90;
+    #validate_script_output "yast2 kdump show 2>&1", sub { m/Kdump is enabled/ }, 90;


not perhaps, please remove :-)

mnowaksuse · 2017-05-22T10:32:19Z

tests/console/kdump_and_crash.pm

+# without any warranty.
+
+# Summary: Run 'crash' utility on a kernel memory dump
+# Maintainer: Michal Nowak <mnowak@suse.com>


Feel free to claim maintainership, or co-maintainership at least.

mnowaksuse · 2017-05-22T10:35:37Z

tests/console/kdump_and_crash.pm

+    select_console 'root-console';
+
+    # soft failure ref bsc#1022064 if kdump could not be enabled
+    return 1 unless kdump_is_active;


Why to just exit the test with soft-fail? Rather die instead as we spotted bug?

There's already a bug for it: https://bugzilla.suse.com/show_bug.cgi?id=957053. And when I run tests, often it fails because kdump doesn't work properly. Should we always let the test fail?

when I run tests, often it fails because kdump doesn't work properly

It looks to me like a definition of product bug. Then the test should always fail. Or I am missing something?

If the test always fails, what do we do with the ticket then? Resolved or rejected? For resolved we need at least one successful test run on o3.

We can always keep the ticket open in "Feedback" status limbo and wait for the product being fixed.

I see. Thanks for the hint.

yxususe · 2017-05-22T12:24:45Z

I've done most modifications, except for die or soft failure part. But there's some issue with test run. I'm still testing it.

foursixnine · 2017-05-23T07:15:19Z

lib/main_common.pm

-        # finished console test and back to desktop
-        loadtest "console/consoletest_finish";
-        # kdump is not supported on aarch64, see BSC#990418
+        # kdump is not supported on aarch64, see bsc#1037407
        if (!check_var('ARCH', 'aarch64')) {


Now that you have kdump_is_active function, you can also enable this for aarch64, we can at least start testing it.

Right. I'll do it.

@foursixnine what do you mean "we can start testing it". bsc#990418 is "RESOLVED WONTFIX" and bsc#1037407 is still open.

@yxususe in this PR please focus on one thing at a time. In this case I recommend to not enable testing on something that can not work. We can later on add it with a special switch to add a scenario to the test development group. We can hardly handle more "known" failures and rather should focus on having some more green jobs first.

@okurz I mean that since the feature is already there, why don't test it?.

Of course. But as long as the bug is still open we won't expect it to pass, no?

yxususe · 2017-05-24T12:38:08Z

I updated PR with Oliver's suggestion to leave enough time for crash:
assert_script_run "$crash_cmd", 600;
validate_script_output "$crash_cmd", sub { m/PANIC/ }, 600;
And so far the result of testruns is good: http://f146.suse.de/tests/348 http://f146.suse.de/tests/352
Now I'm waiting for test result on SLE: http://f146.suse.de/tests/360

okurz · 2017-05-24T14:04:11Z

validation tests look fine so far. I recommend you update your commit message itself and the PR description. Please also revert the change reg. enabling the test for aarch64.

yxususe · 2017-05-24T14:42:02Z

The commit message is updated. Change referring aarch64 is reverted.
Testrun on SLE failed because of a known issue:
Test died: needle 'grub2' not found at /var/lib/openqa/share/tests/sle/lib/opensusebasetest.pm line 348.

os-autoinst#2904

Soulofdestiny added notready WIP Work in progress labels May 17, 2017

okurz changed the title ~~WIP~~ [WIP] kdump test May 17, 2017

foursixnine reviewed May 17, 2017

View reviewed changes

yxususe force-pushed the kdump_test branch from bb5724d to f720c70 Compare May 18, 2017 13:37

yxususe force-pushed the kdump_test branch 2 times, most recently from 02a3ff1 to 68acd17 Compare May 22, 2017 09:40

yxususe force-pushed the kdump_test branch from 68acd17 to 0709f41 Compare May 22, 2017 10:06

mnowaksuse reviewed May 22, 2017

View reviewed changes

okurz reviewed May 22, 2017

View reviewed changes

mnowaksuse reviewed May 22, 2017

View reviewed changes

yxususe force-pushed the kdump_test branch from 0709f41 to 55d67e2 Compare May 22, 2017 12:21

yxususe force-pushed the kdump_test branch from 55d67e2 to 769c931 Compare May 22, 2017 14:15

foursixnine reviewed May 23, 2017

View reviewed changes

yxususe force-pushed the kdump_test branch 2 times, most recently from f4ea83e to b0652d9 Compare May 24, 2017 12:24

Merge kdump and crash test

8e21660

yxususe force-pushed the kdump_test branch from b0652d9 to 8e21660 Compare May 24, 2017 14:38

okurz changed the title ~~[WIP] kdump test~~ kdump test May 24, 2017

okurz merged commit 9495686 into os-autoinst:master May 24, 2017

okurz removed notready WIP Work in progress labels May 25, 2017

dzedro added a commit to dzedro/os-autoinst-distri-opensuse that referenced this pull request May 25, 2017

Fix forgotten crash rename in main.pm

d37e90e

os-autoinst#2904

dzedro mentioned this pull request May 25, 2017

Fix forgotten crash rename in main.pm #2954

Merged

dzedro added a commit to dzedro/os-autoinst-distri-opensuse that referenced this pull request May 25, 2017

Fix forgotten crash rename in main.pm

9bea0a4

os-autoinst#2904

yxususe deleted the kdump_test branch June 8, 2017 10:53

yxususe pushed a commit to yxususe/os-autoinst-distri-opensuse that referenced this pull request Jul 10, 2017

Fix forgotten crash rename in main.pm

8443d35

os-autoinst#2904

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kdump test #2904

kdump test #2904

yxususe commented May 17, 2017

okurz commented May 17, 2017

foursixnine May 17, 2017

yxususe May 18, 2017

yxususe commented May 18, 2017

yxususe commented May 18, 2017

yxususe commented May 22, 2017 •

edited

mnowaksuse commented May 22, 2017

yxususe commented May 22, 2017

mnowaksuse May 22, 2017

mnowaksuse May 22, 2017

okurz May 22, 2017

mnowaksuse May 22, 2017

okurz left a comment

okurz May 22, 2017

okurz May 22, 2017

mnowaksuse May 22, 2017 •

edited by okurz

mnowaksuse May 22, 2017

yxususe May 22, 2017

mnowaksuse May 22, 2017

yxususe May 22, 2017

mnowaksuse May 22, 2017

yxususe May 22, 2017 •

edited

yxususe commented May 22, 2017

foursixnine May 23, 2017

yxususe May 23, 2017

okurz May 24, 2017

foursixnine May 24, 2017

okurz May 25, 2017

yxususe commented May 24, 2017 •

edited

okurz commented May 24, 2017

yxususe commented May 24, 2017

		script_run 'zypper ref';
		zypper_call('-v in $(rpmquery kernel-default \| sed "s/kernel-default/kernel-default-debuginfo/")');

kdump test #2904

kdump test #2904

Conversation

yxususe commented May 17, 2017

okurz commented May 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yxususe commented May 18, 2017

yxususe commented May 18, 2017

yxususe commented May 22, 2017 • edited

mnowaksuse commented May 22, 2017

yxususe commented May 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okurz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mnowaksuse May 22, 2017 • edited by okurz

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yxususe May 22, 2017 • edited

Choose a reason for hiding this comment

yxususe commented May 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yxususe commented May 24, 2017 • edited

okurz commented May 24, 2017

yxususe commented May 24, 2017

yxususe commented May 22, 2017 •

edited

mnowaksuse May 22, 2017 •

edited by okurz

yxususe May 22, 2017 •

edited

yxususe commented May 24, 2017 •

edited