Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opposite disk order on ppc64le #2905

Closed
wants to merge 1 commit into from
Closed

Fix opposite disk order on ppc64le #2905

wants to merge 1 commit into from

Conversation

kravciak
Copy link
Contributor

okurz
okurz reviewed May 18, 2017
View reviewed changes
lib/utils.pm
@@ -252,6 +253,11 @@ sub get_netboot_mirror {
return get_var('MIRROR_' . uc($m_protocol));
}

# Device order in QEMU is switched - bsc#1038275
sub get_extra_disk() {
return check_var('ARCH', 'ppc64le') ? '/dev/vda' : '/dev/vdb';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can we identify the disks by label or id or by reading out something from /etc/fstab? It's unsafe to use hardcoded '/dev/vda' and such
  • Also, this was suggested in the bug itself
  • Also @sysrich changed the qemu version on the ppc64le workers again to 2.9 which should make drive order in line with what the have for x86_64
  • Also we have the same problem for aarch64
  • Also it's not an ARCH-related problem, rather MACHINE (if it all, see above)?

@kravciak
Copy link
Contributor Author

Closing because 2.9 should fix the problem

@kravciak kravciak closed this May 18, 2017
@kravciak kravciak deleted the btrfs branch June 5, 2017 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kravciak @okurz