Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for autoyast minimal profile #3152

Merged
merged 1 commit into from Jun 26, 2017
Merged

Workaround for autoyast minimal profile #3152

merged 1 commit into from Jun 26, 2017

Conversation

kravciak
Copy link
Contributor

poo#18602

@kravciak kravciak requested a review from okurz June 26, 2017 13:33
dzedro
dzedro reviewed Jun 26, 2017
View reviewed changes
tests/autoyast/repos.pm Outdated
@@ -22,7 +22,8 @@ use testapi;
use utils;

sub run {
assert_script_run 'ip addr';
# sles12_minimal.xml profile does not install "ip"
assert_script_run 'ip addr || ifstatus all';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip a less typing ? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks

@okurz
Copy link
Member

okurz commented Jun 26, 2017

LGTM

I assume it actually works regardless of set -o pipefail. I checked locally by setting set -o pipefail and the command does not fail when the first command does not exist.

@okurz okurz merged commit 360da76 into os-autoinst:master Jun 26, 2017
@kravciak kravciak deleted the ay branch November 7, 2017 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzedro dzedro dzedro approved these changes

@okurz okurz Awaiting requested review from okurz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kravciak @okurz @dzedro