Slow type and run very long command in scripted way #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good, but I wouldn't make it arch specific. The type_string is already slower on power, so switching to current_script for all archs would be more consistent in reviewing/error handling |
mitiao
force-pushed
the
validatelr_script
branch
4 times, most recently
from
8578a46
to
31cbcd8
Compare
|
Ok, hope that it would not spent long time on checking dozen repo urls with multiple addons registered :) |
okurz
reviewed
Jun 28, 2017
lib/utils.pm
Outdated
| @@ -66,6 +66,7 @@ our @EXPORT = qw( | |||
| service_action | |||
| assert_gui_app | |||
| install_all_from_repo | |||
| slow_run_scripted_commnad | |||
There was a problem hiding this comment.
s/comnad/command/, or maybe even better name: run_scripted_command_slow to sound similar to type_string_slow
There was a problem hiding this comment.
that sounds good. naming is hard to me sometimes :)
It aims to avoid 'key event queue full' issue. For the detail, see: https://progress.opensuse.org/issues/19540
mitiao
force-pushed
the
validatelr_script
branch
from
31cbcd8
to
85661ef
Compare
|
LGTM |
|
I assume https://openqa.suse.de/tests/1037812#step/zypper_lr/11 is fixed by #3204 ? |
|
Yes, see: https://openqa.suse.de/tests/1038285#step/repos_check/10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It aims to avoid 'key event queue full' issue:
https://openqa.suse.de/tests/1020607
For the detail, see:
https://progress.opensuse.org/issues/19540
Verified run:
http://147.2.207.208/tests/603