Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate uid for two users #3200

Merged
merged 1 commit into from
Jul 3, 2017
Merged

Conversation

rwx788
Copy link
Member

@rwx788 rwx788 commented Jun 30, 2017

In the profile we had same uid for two users, which resulted in failing
installation. Here we simply change bernhard uid in the profile which
make installation work.

See poo#17366 and bsc#1046010

Verification run: http://gershwin.arch.suse.de/tests/533#

In the profile we had same uid for two users, which resulted in failing
installation. Here we simply change bernhard uid in the profile which
make installation work.

See poo#17366 and bsc#1046010
@okurz
Copy link
Member

okurz commented Jun 30, 2017

If the support for duplicate uid was a hidden "feature", shouldn't it still work the same? I commented in https://bugzilla.suse.com/show_bug.cgi?id=1046010#c25

@rwx788
Copy link
Member Author

rwx788 commented Jul 1, 2017

@okurz I believe it was a bug during generation of the profile, so we probably need to add check for this and give a proper error message instead of getting to the state when system doesn't boot normally.

@okurz
Copy link
Member

okurz commented Jul 1, 2017

Sure. So what we could do to make it more obvious is to keep the existing profile but rename the openQA test suite to state "mix_uid_and_non_uid…"?

@rwx788
Copy link
Member Author

rwx788 commented Jul 3, 2017

@okurz We plan to resolve all naming issues at once with https://progress.opensuse.org/issues/20064 once we have tests green. But yes, it totally makes sense.

@okurz
Copy link
Member

okurz commented Jul 3, 2017

Fine. But I am just afraid if I merge this PR that we won't remember so please note it down in the ticket or something, then we can go ahead.

@rwx788
Copy link
Member Author

rwx788 commented Jul 3, 2017

I've added comment on https://progress.opensuse.org/issues/20064 to include this part after we have tests running.

@okurz okurz merged commit d45f534 into os-autoinst:master Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants