Make impress template selection window optional #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Jul 3, 2017
| @@ -74,53 +74,51 @@ sub run() { | |||
|
|
|||
| $self->open_mainmenu(); | |||
| assert_and_click 'mainmenu-office-impress'; #open impress | |||
| assert_screen 'ooimpress-select-a-template'; | |||
| send_key "alt-f4"; #close template window | |||
| send_key 'alt-f4' if check_screen 'ooimpress-select-a-template'; #if there is template window, close it | |||
There was a problem hiding this comment.
Please don't do this check_screen with no timeout by default. You will waste 30 seconds here.
Better use a multi-tag assert_screen plus match_has_tag. Or, if you must, use check_screen …, 0
Fix poo#20070: Window with template selection is optional now, to don't break tests on SLE12-SP3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix poo#20070: Window with template selection is optional now, to don't
break tests on SLE12-SP3.
Verification:
SLE12-SP3: http://pc-pha-base-1.suse.cz/tests/877#step/libreoffice_mainmenu_components/33
SLE12-SP2: http://pc-pha-base-1.suse.cz/tests/878#step/libreoffice_mainmenu_components/33