Add mac80211_hwsim test #3303

nicksinger · 2017-07-17T11:35:24Z

This test is supposed to test the WPA2 enterprise capabilities of hostapd and NetworkManager.
It makes use of the mac80211_hwsim kernel module to simulate real radio hardware.
Right now it is very based on Gnome on Tumbleweed for a first start but should be compatible with all our products after some needle changes.

It does the testing like described here:
https://progress.opensuse.org/issues/20306

A first impression how this looks can be found on my local machine:
http://openqa.glados.qa.suse.de/tests/257

This is how this module looks like in action:
http://openqa.glados.qa.suse.de/tests/282#step/consoletest_setup/29

Required needles: os-autoinst/os-autoinst-needles-opensuse#236

Feedback and critique heavily welcome!

okurz · 2017-07-17T12:27:30Z

tests/x11/mac80211_hwsim.pm

+# notice and this notice are preserved.  This file is offered as-is,
+# without any warranty.
+
+# Summary: mac80211 hw test


Please add some more here, I know you can do :-) Describe the purpose of the test, limitations, etc.

okurz · 2017-07-17T12:27:57Z

tests/x11/mac80211_hwsim.pm

+# Tags: poo#20306
+
+use base 'x11test';
+use y2x11test qw(launch_yast2_module_x11);


use single ticks, probably perlcritic will also tell this

use single ticks

okurz · 2017-07-17T12:29:57Z

tests/x11/mac80211_hwsim.pm

+    send_key 'tab';
+    type_string 'nots3cr3t';
+
+    # aat 'connect'


leftover comments

okurz · 2017-07-17T12:30:59Z

tests/x11/mac80211_hwsim.pm

+    y2x11test::launch_yast2_module_x11;
+    $self->yast_search('Network Settings');
+
+    # assert_and_click 'yast2-networksettings'


some of these comments are a bit to verbose and don't add information. Looks like left-overs from initial pseudo code? Better delete some comments now.

yes, definitely leftovers from pseudocode

okurz · 2017-07-17T12:31:25Z

tests/x11/mac80211_hwsim.pm

+    # softfail yast2 error
+    #   aac 'ok'
+    if (check_screen 'yast2_network-error_dialog') {
+        record_soft_failure 'bsc#TODO';


if you don't have a bugref better just make it a die with a hint what to report a but about.

okurz · 2017-07-17T12:32:00Z

tests/x11/mac80211_hwsim.pm

+    # assert 'saving-is-running'
+    # softfail yast2 error
+    #   aac 'ok'
+    if (check_screen 'yast2_network-error_dialog') {


please don't use check_screen with default timeout or higher as this would waste time in case everything is ok. Better use a multi-tag assert_screen in combination with match_has_tag

okurz · 2017-07-17T12:32:49Z

tests/x11/mac80211_hwsim.pm

+        }
+    }
+    type_string $name if $name;
+}


In case you just copied this from the yast2_control_center test better extract it into a common base class

okurz · 2017-07-17T12:36:01Z

tests/x11/mac80211_hwsim.pm

+    $self->generate_certs;
+    $self->configure_hostapd;
+    $self->reload_services;
+    type_string "exit\n";


Don't log out of the root console. You can call utils::clear_console if you prefer

okurz · 2017-07-18T11:12:29Z

It's not done when you don't update the PR, the PR message still states WIP and checks fail

nicksinger · 2017-07-18T11:53:42Z

Therefore commit ~~1dafa48~~ a177e40. I tried to address most of your mentioned improvements and made the test to complete. A run with the recent changes can be seen here: http://openqa.glados.qa.suse.de/tests/282

I'm not 100% sure how to handle this recommendation from you about the assert_screen but will ask you in person. ~~The failing test (and tidy) I want to address in the next commit.~~

Anything to improve about the current code base?

okurz · 2017-07-18T12:03:28Z

update PR message, remove the WIP part

okurz · 2017-07-18T12:04:16Z

tests/x11/mac80211_hwsim.pm

+# Tags: poo#20306
+
+use base 'x11test';
+use y2x11test qw(launch_yast2_module_x11);


use single ticks

okurz · 2017-07-18T12:06:22Z

tests/x11/mac80211_hwsim.pm

+
+    ## we have to change the networkmanager form wicked to NetworkManager
+    #y2x11test::launch_yast2_module_x11;
+    #$self->yast_search('Network Settings');


why disabled?

y2x11test::launch_yast2_module_x11 is able to open yast modules directly. This results in less duplicate code (e.g. the yast2 search function is not needed anymore). The comment is mainly for me to not check in these needles

okurz · 2017-07-18T12:06:27Z

tests/x11/mac80211_hwsim.pm

+
+    ## open the 'Network Settings'
+    #assert_and_click 'yast2_control-center_network-check';
+    #assert_screen 'yast2_control-center_network-opened';


why disabled?

see comment above

okurz · 2017-07-18T13:33:28Z

LGTM, I will enable the test in the test plan

…st#3303

Enable the new mac80211_hwsim wifi simulation test added by #3303

…st#3303

Add mac80211_hwsim test

b8464a8

okurz reviewed Jul 17, 2017

View reviewed changes

nicksinger force-pushed the mac80211_hwsim_test branch from 1dafa48 to a177e40 Compare July 18, 2017 12:02

okurz reviewed Jul 18, 2017

View reviewed changes

nicksinger force-pushed the mac80211_hwsim_test branch from a177e40 to 4aaeb33 Compare July 18, 2017 12:13

Complete test and improve minor things

661a0fb

nicksinger force-pushed the mac80211_hwsim_test branch from 4aaeb33 to 661a0fb Compare July 18, 2017 12:31

nicksinger mentioned this pull request Jul 18, 2017

Add mac80211_hwsim needles os-autoinst/os-autoinst-needles-opensuse#236

Merged

nicksinger changed the title ~~[WIP] Add mac80211_hwsim test~~ Add mac80211_hwsim test Jul 18, 2017

okurz merged commit 272f597 into os-autoinst:master Jul 18, 2017

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jul 18, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

27a1877

…st#3303

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jul 18, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

c5a3646

…st#3303

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jul 18, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

0bd468e

…st#3303

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jul 19, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

a0cf3c5

…st#3303

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Jul 20, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

22ca2f5

…st#3303

nicksinger pushed a commit to nicksinger/os-autoinst-distri-opensuse that referenced this pull request Jul 20, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

538e572

…st#3303

okurz added a commit to okurz/os-autoinst-distri-opensuse that referenced this pull request Sep 22, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

a62b2ea

…st#3303

okurz added a commit that referenced this pull request Sep 29, 2017

Merge pull request #3313 from okurz/feature/enable_hwsim_wifi

b594250

Enable the new mac80211_hwsim wifi simulation test added by #3303

rwx788 pushed a commit to rwx788/os-autoinst-distri-opensuse that referenced this pull request Oct 5, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

a8c5a19

…st#3303

yxususe pushed a commit to yxususe/os-autoinst-distri-opensuse that referenced this pull request Oct 23, 2017

Enable the new mac80211_hwsim wifi simulation test added by os-autoin…

b397173

…st#3303

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add mac80211_hwsim test #3303

Add mac80211_hwsim test #3303

nicksinger commented Jul 17, 2017 •

edited

Loading

okurz Jul 17, 2017

nicksinger Jul 17, 2017

okurz Jul 17, 2017

okurz Jul 18, 2017

okurz Jul 17, 2017

nicksinger Jul 17, 2017

okurz Jul 17, 2017

nicksinger Jul 17, 2017

okurz Jul 17, 2017

okurz Jul 17, 2017

okurz Jul 17, 2017

okurz Jul 17, 2017

okurz commented Jul 18, 2017

nicksinger commented Jul 18, 2017 •

edited

Loading

okurz commented Jul 18, 2017

okurz Jul 18, 2017

okurz Jul 18, 2017

nicksinger Jul 18, 2017 •

edited

Loading

okurz Jul 18, 2017

nicksinger Jul 18, 2017

okurz commented Jul 18, 2017

Add mac80211_hwsim test #3303

Add mac80211_hwsim test #3303

Conversation

nicksinger commented Jul 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okurz commented Jul 18, 2017

nicksinger commented Jul 18, 2017 • edited Loading

okurz commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicksinger Jul 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okurz commented Jul 18, 2017

nicksinger commented Jul 17, 2017 •

edited

Loading

nicksinger commented Jul 18, 2017 •

edited

Loading

nicksinger Jul 18, 2017 •

edited

Loading