Adjust boot image creation with repos on sle 15 #3370
Conversation
rwx788
force-pushed
the
20582_sle_version_15
branch
from
7060340
to
6cc4d47
Compare
lib/y2logsstep.pm
Outdated
| sub sle15_workaround_broken_patterns { | ||
| return unless sle_version_at_least('15'); | ||
| # SLE 15 has pattern errors, workaround them - rbrown 04/07/2017 | ||
| while (check_screen('sle-15-failed-to-select-pattern')) { |
There was a problem hiding this comment.
why did you change the timeout? This will now cause a lot of waiting time, 30 seconds default. Do you think less could work?
There was a problem hiding this comment.
My bad, missed that when was resolving a conflict. Good catch.
rwx788
force-pushed
the
20582_sle_version_15
branch
from
6cc4d47
to
77fbfcd
Compare
rwx788
changed the title
|
@okurz If we don't want to wait, we can merge this PR and see where test will fail afterwards. |
rwx788
changed the title
|
Additional changes will be required as after resolving package conflicts we get back to overview page and get same error again. |
rwx788
force-pushed
the
20582_sle_version_15
branch
from
77fbfcd
to
646f8e7
Compare
rwx788
changed the title
tests/installation/grub_test.pm
Outdated
| @@ -59,7 +59,7 @@ sub run { | |||
| } | |||
| workaround_type_encrypted_passphrase; | |||
| # 60 due to rare slowness e.g. multipath poo#11908 | |||
| assert_screen "grub2", 60; | |||
| assert_screen "grub2", 300; | |||
There was a problem hiding this comment.
Hack, as somehow system boots to the iso after reboot. With increased timeout we start booting from hdd and everything works well.
There was a problem hiding this comment.
Are you sure this also happened in production? It will happen when you do tests locally with loading from qemu screenshots so that you never finish the normal installation from start to end. Then your machine boots from DVD as well then.
There was a problem hiding this comment.
This may explain it. I'll do full verification run and see if anything needed here.
We already have a method to workaround broken patterns, whereas in some scenarios we have installation_overview_before where we just assert overview screen. As a temporary solution we will add repos manually before we get scc. Whereas, it should not affect test code, as this part is done using test suite configuration. This PR mainly contains changes to workaround known installation issues. We also exclude release notes test on sle 15 as it doesn't work properly with addons and there will be no such a thing visible in future. See poo#20984
rwx788
force-pushed
the
20582_sle_version_15
branch
from
646f8e7
to
f37deb0
Compare
rwx788
changed the title
rwx788
changed the title
|
Set back to WIP to address issue with REPO and ADDON_URL variables. To have single test suite for SLE 12 and SLE 15 we need to set variables correctly in main.pm. Blocked on this merge request |
|
+1 |
rwx788
force-pushed
the
20582_sle_version_15
branch
4 times, most recently
from
70ee50e
to
cabc290
Compare
| @@ -51,7 +51,7 @@ sub run { | |||
| # might involve some network lookup of products, licenses, etc. | |||
| assert_screen 'addon-products', 90; | |||
| send_key "tab"; # select addon-products-$addon | |||
| wait_still_screen 2; | |||
| wait_still_screen 10; | |||
There was a problem hiding this comment.
In my local setup list is shown as empty first, then gets to initializing and then proper content is shown. Otherwise, start navigating in menu without a change to reach the list
| @@ -96,6 +96,7 @@ sub run { | |||
| send_key 'alt-t'; | |||
| } | |||
| send_key "tab"; # select addon-products-$addon | |||
| wait_still_screen 10; # wait until repo is added and list is initialized | |||
rwx788
force-pushed
the
20582_sle_version_15
branch
2 times, most recently
from
7d88958
to
279ed51
Compare
rwx788
force-pushed
the
20582_sle_version_15
branch
from
279ed51
to
4aa9a40
Compare
rwx788
changed the title
We already have a method to workaround broken patterns, whereas in some
scenarios we have installation_overview_before where we just assert
overview screen.
As a temporary solution we will add repos manually before we get scc.
Whereas, it should not affect test code, as this part is done using test
suite configuration. This PR mainly contains changes to workaround known
installation issues. We also exclude release notes test on sle 15 as it doesn't
work properly with addons and there will be no such a thing visible in
future.
See poo#20824 and poo#20984
NOTE: all workaround take place only on sle15, hence won't affect other versions.
This change is partly included in PR#3353.
Verification runs:
SLE15 minimal base + SDK
SLE15 text mode create hdd
SLE12 SP3 minimal base + SDK
Needles MR#442 - already merged
Needles MR#443 - needs merge.