Also ensure SCC_EMAIL is not typing nothing #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nah, I was wrong. Also SLE 12 SP3 works fine with no email address: https://openqa.suse.de/tests/1058778#step/scc_registration/2 |
Also ensure SCC_EMAIL is not typing nothing and therefore fix a warning about type_string called on an undef value. However we want to still be able to test an empty regcode (and email) typing explicitly. See https://openqa.suse.de/tests/1129995#step/scc_registration/2
|
LGTM |
|
@rwx788 I updated the commit to just prevent perl warnings when trying to call |
|
We could have used get_var('SCC_EMAIL', '') then. But fine, doesn't hurt much. |
|
@rwx788 so call type_string with an empty string? Not much better IMHO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://openqa.suse.de/tests/1129995#step/scc_registration/2
Related progress issue: https://progress.opensuse.org/issues/23506