Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal+base+sdk+proxy_SCC-postreg for SLE15 #3475

Closed
wants to merge 0 commits into from

Conversation

yxususe
Copy link
Contributor

@yxususe yxususe commented Aug 28, 2017

@yxususe yxususe force-pushed the proxyscc_postreg branch 3 times, most recently from d2d712a to 6f3cc9e Compare August 29, 2017 08:01
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attend all comments from #3428 first

Also SUSEConnect -r SCC_REGCODE won't work

@yxususe yxususe force-pushed the proxyscc_postreg branch 2 times, most recently from 0532fb4 to e57541c Compare August 31, 2017 09:25
@yxususe
Copy link
Contributor Author

yxususe commented Aug 31, 2017

@yxususe yxususe force-pushed the proxyscc_postreg branch 3 times, most recently from 06c92ab to 1921147 Compare August 31, 2017 12:55
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned before, we already have test where we do registration, but not with SUSEConnect tool, but with gui interface. So it doesn't make sense to have both unless you deactivate all modules and registration before running yast_scc. Or it hast to be separate test suite. Test module itself looks good.

@@ -0,0 +1,47 @@
# Copyright (C) 2014-2017 SUSE LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use only 2017 here

# You should have received a copy of the GNU General Public License along
# with this program; if not, see <http://www.gnu.org/licenses/>.

# Summary: Do the registration against SCC after installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add details, that registration is done with SUSEConnect tool and not with yast scc.

@yxususe
Copy link
Contributor Author

yxususe commented Sep 7, 2017

Basically I agree with Rodion, that one either registers modules with SuSEConnect (when sle version>=15), or with yast scc. However Oliver has different opinions. We have to talk in person about it.

@rwx788
Copy link
Member

rwx788 commented Sep 7, 2017

@yxususe SuSEConnect tool can be used with SLE12 as well, but modules are obviously not there. I'm not sure if @okurz has different opinion here, we just need separate test suite. Let's when till Monday.

@okurz
Copy link
Member

okurz commented Sep 7, 2017

yes, please wait until Monday and let's rediscuss then.

my $scc_url = get_var("SCC_URL");

select_console 'root-console';
assert_script_run "SUSEConnect --url $scc_url" if $scc_url;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this in latest builds, not sure how it worked before, but if we redefined $scc_url, we should provide reg code within same command. So, it should be "SUSEConnect --url $scc_url -r $reg_code". Please, change this accordingly, but still having a fallback to registration against official SCC when SCC_URL is not defined.

@yxususe yxususe closed this Sep 19, 2017
@yxususe yxususe deleted the proxyscc_postreg branch September 19, 2017 09:04
@yxususe yxususe restored the proxyscc_postreg branch September 19, 2017 09:05
@yxususe yxususe changed the title WIP - minimal+base+sdk+proxy_SCC-postreg for SLE15 minimal+base+sdk+proxy_SCC-postreg for SLE15 Sep 19, 2017
@yxususe
Copy link
Contributor Author

yxususe commented Sep 19, 2017

Somehow I did some wrong operation and I will open a new PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants