New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal+base+sdk+proxy_SCC-postreg for SLE15 #3475
Conversation
d2d712a
to
6f3cc9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attend all comments from #3428 first
Also SUSEConnect -r SCC_REGCODE
won't work
0532fb4
to
e57541c
Compare
06c92ab
to
1921147
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned before, we already have test where we do registration, but not with SUSEConnect tool, but with gui interface. So it doesn't make sense to have both unless you deactivate all modules and registration before running yast_scc. Or it hast to be separate test suite. Test module itself looks good.
tests/console/proxyscc_postreg.pm
Outdated
@@ -0,0 +1,47 @@ | |||
# Copyright (C) 2014-2017 SUSE LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use only 2017 here
tests/console/proxyscc_postreg.pm
Outdated
# You should have received a copy of the GNU General Public License along | ||
# with this program; if not, see <http://www.gnu.org/licenses/>. | ||
|
||
# Summary: Do the registration against SCC after installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add details, that registration is done with SUSEConnect tool and not with yast scc.
Basically I agree with Rodion, that one either registers modules with SuSEConnect (when sle version>=15), or with yast scc. However Oliver has different opinions. We have to talk in person about it. |
yes, please wait until Monday and let's rediscuss then. |
tests/console/proxyscc_postreg.pm
Outdated
my $scc_url = get_var("SCC_URL"); | ||
|
||
select_console 'root-console'; | ||
assert_script_run "SUSEConnect --url $scc_url" if $scc_url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this in latest builds, not sure how it worked before, but if we redefined $scc_url, we should provide reg code within same command. So, it should be "SUSEConnect --url $scc_url -r $reg_code". Please, change this accordingly, but still having a fallback to registration against official SCC when SCC_URL is not defined.
1921147
to
614a486
Compare
Somehow I did some wrong operation and I will open a new PR for it. |
Solution for https://progress.opensuse.org/issues/19566.