Adjust RAID test for storage ng #3548
Conversation
rwx788
force-pushed
the
23340_storage_ng_raid0
branch
from
ecf0157
to
e12dec6
Compare
| @@ -57,16 +57,16 @@ sub addpart { | |||
| send_key "alt-a"; # Raw Volume | |||
| send_key $cmd{next}; | |||
| assert_screen 'partition-format'; | |||
| send_key $cmd{donotformat}; | |||
There was a problem hiding this comment.
Because for non-storage ng key is still valid.
There was a problem hiding this comment.
I'm not stupid. But can you define hotkeys based on is_storage_ng and use that with a proper name instead of hard-coding it here?
I see two benefits of the hotkey table:
- Simplifies setup of an openQA test based on a different INSTLANG setting which we want to have eventually
- Provides helpful names for the variables instead of a comment
There was a problem hiding this comment.
If you saw the code, we recognize if it's storage ng or not in partitioning test module, so we cannot define it before the execution. But possibly we can redefine them in that module, yes. So the only advantage will be hard-coding all keys in one place which may make it even more confusing.
There was a problem hiding this comment.
Unfortunately I have only a single key which has same functionality, but different shortcut in storage-ng, so these changes are introduced in partitioning.pm test module which is executed before and defines STORAGE_NG variable dynamically.
|
|
||
| assert_screen 'custompart_systemview-selected'; | ||
| send_key "down"; | ||
| assert_screen 'partitioning_raid-hard_disks-selected'; | ||
|
|
||
|
|
||
|
|
rwx788
force-pushed
the
23340_storage_ng_raid0
branch
from
e12dec6
to
1430745
Compare
Functionality still doesn't fully work, but with this change we will fail at the point where there is a bug. I've introduced changes to proceed using different format for disk size, but if fails later because custom size doesn't work still. See poo#23340.
rwx788
force-pushed
the
23340_storage_ng_raid0
branch
from
1430745
to
df70458
Compare
Functionality still doesn't fully work, but with this change we will
fail at the point where there is a bug. I've introduced changes to
proceed using different format for disk size, but if fails later because
custom size doesn't work still.
Please, do not forget to merge NEEDLES
See poo#23340.
Verification runs:
SLE15
SLE12SP3