Fix sporadic incompletes on zkvm in reconnect_s390 #3612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as on zVM we need to disable VNC stall detection on zkvm connections to the installation console which is a VNC connection that may disappear on reconnecting to the restarting SUT. The problem looks like http://lord.arch/tests/7446 Verification run: * zkvm: http://lord.arch/tests/7448 * zVM: http://lord.arch/tests/7449 Related progress issue: https://progress.opensuse.org/issues/19350
| @@ -40,14 +40,14 @@ sub handle_login_not_found { | |||
|
|
|||
| sub run { | |||
| my $login_ready = check_var('VERSION', 'Tumbleweed') ? qr/Welcome to openSUSE Tumbleweed 20.*/ : qr/Welcome to SUSE Linux Enterprise .*\(s390x\)/; | |||
| console('installation')->disable_vnc_stalls; | |||
There was a problem hiding this comment.
this is already done before in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/utils.pm#L181
which is called at the end of install_and_reboot
There was a problem hiding this comment.
maybe. But pulling it out of the "if-backend" will make code cleaner and might even help ;-) I think I need to conduct some more experiments for statistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as on zVM we need to disable VNC stall detection on zkvm connections to
the installation console which is a VNC connection that may disappear on
reconnecting to the restarting SUT. The problem looks like
http://lord.arch/tests/7446
Verification run:
Related progress issue: https://progress.opensuse.org/issues/19350