Older versions of Leap&SLE+non-UEFI also have other hotkey #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioAtSUSE
force-pushed
the
fix_bootloader_hotkey_42.2_no_uefi
branch
from
84259b6
to
fe1ce33
Compare
SergioAtSUSE
force-pushed
the
fix_bootloader_hotkey_42.2_no_uefi
branch
from
fe1ce33
to
911d973
Compare
okurz
reviewed
Oct 20, 2017
| $cmd{bootloader} = 'alt-t'; # older versions | ||
| } | ||
| elsif (is_leap) { | ||
| if (is_leap && check_var('VERSION', '15')) { |
There was a problem hiding this comment.
no, don't use a version specific check. We don't want to revisit this for '15.0' or '15-SP1'. What's wrong with the old code?
There was a problem hiding this comment.
The problem of the old one, is that it is a too complicated if-else-statements when the only version that doesn't match the pattern (UEFI->t, non-UEFI->r) is Leap 15. So I simplified the to a single if-statement.
Would it be better if I use?:
if (is_leap && leap_version_at_least('15')
| $cmd{bootloader} = 'alt-l'; # leap 15 | ||
| } | ||
| else { | ||
| $cmd{bootloader} = check_var('UEFI', '1') ? 'alt-t' : 'alt-r'; # rest except uefi | ||
| $cmd{bootloader} = check_var('UEFI', '1') ? 'alt-t' : 'alt-r'; # UEFI or non-UEFI |
There was a problem hiding this comment.
IMHO the comment is redundant anyway. There is a check for UEFI so no need to write "UEFI or non-UEFI".
|
Superseeded by: #3762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Verification run