Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disable timeout by typing slowler #3777

Closed
wants to merge 0 commits into from
Closed

Conversation

jknphy
Copy link
Contributor

@jknphy jknphy commented Oct 23, 2017

Fix typing speed to avoid that only "-" is detected and after "ret" in text mode the textbox comes back to "0", like in the following examples:
https://openqa.suse.de/tests/1230788#step/disable_grub_timeout/5
https://openqa.suse.de/tests/1231104#step/disable_grub_timeout/8

Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@okurz
Copy link
Member

okurz commented Oct 23, 2017

-1, type_string_slow will only induce a waiting time between characters. Without a proper check we don't know if this helps anything therefore I disagree. I recommended in #3778 to disable the test module again until we know for sure, i.e. reproduce locally (e.g. fails in 1/10 runs), apply change and verify it improves (e.g. fails 0/40 runs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants