Replace unreliable keyboard shortcut by a mouse click

[nicksinger]

https://openqa.suse.de/tests/1124996?version=15&distri=sle&flavor=Leanos-DVD&test=gnome&arch=x86_64&machine=64bit-ipmi&limit_previous=100#step/partitioning_firstdisk/3 tries hard to press alt+e while the shortcut is alt+u in reality. It then fails in the next step because no partition is big enough (caused by pressing the wrong shortcut).

We already have a needle that checks exactly for that button so why not make use of it and just click it.

The change in run() is just to make it more pretty.

Note: Not sure if this code path is still touched somewhere. I'm pretty sure this is needed for SLE12 since it does not contain storage_ng. I'll try to run an old SLE12 job to verify this change and leave this PR as [WIP] until then.

• Related ticket: https://progress.opensuse.org/issues/23566
• Needles: not needed
• Verification run:
  • SLE12SP3: http://openqa.glados.qa.suse.de/tests/564#step/partitioning_firstdisk/3
  • TW: http://dhcp227.suse.cz/tests/272#step/partitioning_firstdisk/2
  • SLE15: not affected

[okurz]

You can also run a SLE12SP4 job for validation, e.g. clone https://openqa.suse.de/tests/1239811 and overwrite settings as needed to check.

[jknphy]

When Release note button disappears like in this case, shortcuts are changed automatically.
You are in [WIP] but I guess you want to remove block with send_key 'alt-e';.
Let me add this verification runs in case I got the correct idea of what you are trying to do:
http://localhost/tests/272#step/partitioning_firstdisk/2
To look for important moment in the logs to check in this job above, search in autoinst-log.txt for: 13:12:25.3320 Debug: /var/lib/openqa/share/tests/opensuse/tests/installation/partitioning_firstdisk.pm:75 called testapi::assert_and_click

I didn't find a way to handle to have a previously partitioned disk for SLE12SP4 to run validation using parameters, SELECT_FIRST_DISK=1 NUMDISKS=2 was not enough, need a .qcow image with that previous partition present.

[Soulofdestiny]

works if you use dhcp227.suse.cz instead of localhost ;)
http://dhcp227.suse.cz/tests/272#step/partitioning_firstdisk/2

[okurz]

@nicksinger to check where this test module is executed you can query the database directly and list jobs last executing this test module, e.g. take a look in my github repo okurz/scripts

[nicksinger]

awesome script, will definitely remember this one in the future.
I've added the verification runs to my initial message - this PR should be ready for review/merge now.

[okurz]

Aren't we calling the same test module in textmode as well? Can you check/test that?

[nicksinger]

True