Adapt encrypted_volume_activation for storage-ng #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification run: http://lord.arch/tests/8041 Related needles MR: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/561 Related progress issue: https://progress.opensuse.org/issues/27018
okurz
force-pushed
the
fix/encrypt_activation
branch
from
80126cd
to
c12450d
Compare
asmorodskyi
reviewed
Nov 8, 2017
| send_key 'alt-p'; | ||
| assert_screen 'encrypted_volume_password_prompt'; | ||
| type_password; | ||
| send_key 'ret'; |
There was a problem hiding this comment.
isn't this line is doing same as line 47 just in different way ? can we keep this consistent ?
There was a problem hiding this comment.
I would even go further . what about such refactor :
if (! match_has_tag 'encrypted_volume_activation_prompt-embedded_password_prompt') {
send_key 'alt-p';
assert_screen 'encrypted_volume_password_prompt';
}
type_password;
send_key 'ret';
There was a problem hiding this comment.
you can replace send_key 'ret' with send_key $cmd{ok} it doesn't matter
There was a problem hiding this comment.
no, unfortunately it does not seem to behave the same. In the new dialog somehow there is no button pre-selected so 'ret' does not do anything because no button is focused but only the password prompt. This is why I kept it separate. I did not want to change old behaviour and did not check if 'ok' works in the old way. Can we keep it as is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification run: http://lord.arch/tests/8041
Related needles MR:
https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/561
Related progress issue: https://progress.opensuse.org/issues/27018