FIX update packagekit gpk on Leap #3961
Conversation
|
@SergioAtSUSE @andreasstieger this should fix the tests on leap |
There was a problem hiding this comment.
@DrMullings, please add a verification run for Leap 42.3 and Leap 15 too.
| @@ -77,7 +77,8 @@ sub run { | |||
| if (match_has_tag("updates_none")) { | |||
| send_key 'ret'; | |||
| if (check_screen "updates_installed-restart", 0) { | |||
| power_action 'reboot'; | |||
| select_console 'root-sonsole'; | |||
| type_string "reboot\n"; | |||
There was a problem hiding this comment.
I am not sure if this is the right approach. @okurz already told you to use power_action. Maybe the function power_action needs to be adapted to also care of this use case?
There was a problem hiding this comment.
That should be the next step, yes.
But I think its more important to get it running first and then fix cosmetic stuff afterwards
@okurz whats you opinion on this?
|
If I see verification runs for Leap 42.3 and 15, I can give LGTM and merge |
Exchanged the power_action 'reboot' with a manual approach since reboot_x11 did not work
DrMullings
force-pushed
the
FIX_update_gpk
branch
from
01f4f8c
to
551c47b
Compare
|
Leap 42.3: http://pinky.arch.suse.de/tests/251 |
|
I can confirm that the test failures noted in #3941 (comment) are fixed by this. |
Exchanged the power_action 'reboot' with a manual approach
since reboot_x11 did not work