Add bios boot partition for storage-ng for RAID #4009
Conversation
| @@ -74,6 +74,7 @@ sub init_cmd { | |||
| entiredisk alt-e | |||
| guidedsetup alt-g | |||
| rescandevices alt-e | |||
| exp_part_finish alt-f | |||
There was a problem hiding this comment.
sorry I am totally out of concept behind this $cmd but what the point to define something in one place to redifine it in another ?
There was a problem hiding this comment.
Here we define default key and for storage-ng these are different, so we redefine it, but in the code we can use same hash key without conditional switches.
There was a problem hiding this comment.
and this is the way to go for testing localization eventually :)
| @@ -60,9 +61,14 @@ sub addpart { | |||
| send_key $cmd{donotformat}; | |||
| send_key "tab"; | |||
| send_key 'alt-i' if is_storage_ng; # Select file system | |||
| my $partition_type; | |||
There was a problem hiding this comment.
Nice catch, that's remains of on if the approaches, thanks!
| assert_screen 'partitioning_raid-disk_vdd_with_partitions-selected'; | ||
| # fold the drive tree | ||
| send_key 'left'; | ||
| assert_screen 'partitioning_raid-hard_disks-unfolded'; |
There was a problem hiding this comment.
not saying it really should be like this but just thinking loud - can we replace all this send_key + assert_screen with send_key_until_needlematch ?
There was a problem hiding this comment.
We can do that, but in some places it's about single key press, so I don't see much value in it, except more stability, which is not an issue currently
There was a problem hiding this comment.
@asmorodskyi I thought about the same. We can make it more explicit by adding a new function send_key_and_assert_screen left => 'partitioning_raid-hard_disks-unfolded' but I don't think it will help much. OTOH if by doing this we can encourage more users to do this by default and not try to call multiple send_key in a row without checking results in between then maybe it would help
| } | ||
| if (!get_var('UEFI')) { # partitioning type does not appear when GPT disk used, GPT is default for UEFI | ||
| if (is_storage_ng) { | ||
| record_soft_failure 'bsc#1055743'; # No partitioning type page ATM |
There was a problem hiding this comment.
check the bug - currently it has state "VERIFIED INVALID"
There was a problem hiding this comment.
You're right, we can fix that here as well.
There was a problem hiding this comment.
Have changed that in 2 places
As per bsc#1063957 there is a change in behavior and now bios boot partition is required for storage-ng. See [poo#28573](https://progress.opensuse.org/issues/28573).
|
Needles PR still have WIP so can't merge |
|
@asmorodskyi This PR is also WIP, we are waiting for the bug fix first, which should happen in staging in TW and after that we can apply it to the production. |
|
except for WIP LGTM |
|
WIP label was removed 4 days ago - does this mean it's good to go? (and fixes by Staging:E ?) |
As per bsc#1063957 there is a change in behavior and now bios boot
partition is required for storage-ng.
Related ticket: poo#28573.
Needles openSUSE
Needles SLE
Verification run openSUSE
Verification run SLE