Add new timezone selection to Evolution #4067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolo
reviewed
Dec 13, 2017
| @@ -38,8 +39,15 @@ sub run { | |||
| send_key "alt-s"; | |||
| wait_still_screen 3; | |||
| send_key "ret"; | |||
| send_key_until_needlematch("timezone-asia-shanghai", "up") | |||
| || send_key_until_needlematch("timezone-asia-shanghai", "down"); | |||
| if (sle_version_at_least('12-SP3')) { | |||
There was a problem hiding this comment.
hmm. I would prefer if you did this without hardcoding versions - but by means of a check_screen. Because leap will get this update too I assume - and then you end up with strange version checks.
Fix poo#29363: Evolution changed timezone selection dialog in SLE12-SP3.
|
@coolo test was updated as suggested, links to verification runs were updated in description |
|
@coolo could you please merge needles too? |
|
makes sense, no? 😺 |
rwx788
pushed a commit
to rwx788/os-autoinst-distri-opensuse
that referenced
this pull request
Dec 14, 2017
Fix poo#29363: Evolution changed timezone selection dialog in SLE12-SP3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix poo#29363: Evolution changed timezone selection dialog in SLE12-SP3.
SP3 new behavior: http://10.100.12.105/tests/737#step/evolution_timezone_setup/61
SP2 old behavior: http://10.100.12.105/tests/738#step/evolution_timezone_setup/79