Fix poo #28648 #4105
Closed
Fix poo #28648 #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an exception for QAM CaaSP workflow in respect to autoyast. This is required for the stability of our scenarios. The `generic` autoyast test is using _too many_ needle tags, thus our systems are prone to miss the `bios-boot` tag/needle when we deploy a *10-node* CaaSP cluster. The reason behind this is that we are using autoyast just to bring the workers up to the defined state. Any error that happens in between, is not really important to capture it _on time_. In any case, if something breaks during the autoyast installation, we will encounter it anyway in the end of the installation. Simply put, risking the stability of our tests in order to save a couple of minutes it's something we would like to avoid. As a result, this PR removes the ability of consistantly scanning for errors during the autoyast installation, but it keeps looking for the only needle we care specifically.
drpaneas
force-pushed
the
qam_autoyast
branch
from
76ab993
to
d2599df
Compare
rwx788
reviewed
Dec 20, 2017
|
|
||
| # QAM CaaSP specific | ||
| if (is_caasp && check_var('FLAVOR', 'CaaSP-DVD-Incidents')) { | ||
| assert_screen('bios-boot', 1200); |
There was a problem hiding this comment.
I guess it will be easier to adjust needles array for this scenario, and just put one needle there and using same code as before. I also not sure if it's really what you want to see, as you can ignore warning/errors in the profile. This loop helps to fail test before it times out in 2 hours, which is good from many perspectives. So I would leave at least 'bios-boot' and 'linuxrc-install-fail'. You may also introduce needle which is there when system is already booted, then we don't care that we have missed bios-boot
There was a problem hiding this comment.
yeah, doesn't make much sense. Can you reject this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an exception for QAM CaaSP workflow in respect to autoyast.
This is required for the stability of our scenarios. The
genericautoyast test is using too many needle tags, thus our systems
are prone to miss the
bios-boottag/needle when we deploy a10-node CaaSP cluster.
The reason behind this is that we are using autoyast just to bring
the workers up to the defined state. Any error that happens in
between, is not really important to capture it on time. In any
case, if something breaks during the autoyast installation, we will
encounter it anyway in the end of the installation.
Simply put, risking the stability of our tests in order to save
a couple of minutes it's something we would like to avoid.
As a result, this PR removes the ability of consistantly scanning
for errors during the autoyast installation, but it keeps looking
for the only needle we care specifically.