Stop serial grab where necessary #4107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnowaksuse
force-pushed
the
disable_serial_console_on_shutdown
branch
from
02fdb8d
to
569b19a
Compare
dasantiago
reviewed
Dec 29, 2017
lib/utils.pm
Outdated
| if ($action eq 'reboot') { | ||
| reset_consoles; | ||
| # Set disk as a primary boot device | ||
| console('svirt')->change_domain_element(os => boot => {dev => 'hd'}); | ||
| console('svirt')->define_and_start; | ||
| console('svirt')->start_serial_grab; |
There was a problem hiding this comment.
Is this necessary? The define_and_start function is already invoking start_serial_grab.
dasantiago
reviewed
Dec 29, 2017
lib/utils.pm
Outdated
| @@ -643,6 +641,7 @@ sub power_action { | |||
| if (check_var('BACKEND', 'svirt')) { | |||
There was a problem hiding this comment.
wouldn't be better if this IF condition was moved into the prepare_system_shutdown function?
mnowaksuse
force-pushed
the
disable_serial_console_on_shutdown
branch
from
569b19a
to
182f219
Compare
mnowaksuse
changed the title
added 2 commits
January 2, 2018 10:33
Fixes poo#16418: "svirt: openQA won't perform another query_isotovideo check when VM is down -> incompletes" (second part in os-autoinst). Validation run: http://assam.suse.cz/tests/95 (restarted 20 times in revive_xen_domain test module). ``` [2017-12-20T14:34:04.0946 CET] [debug] /var/lib/openqa/share/tests/sle/tests/jeos/revive_xen_domain.pm:24 called utils::power_action [2017-12-20T14:34:04.0946 CET] [debug] <<< backend::console_proxy::__ANON__(wrapped_call={ 'console' => 'svirt', 'function' => 'stop_serial_grab', 'args' => [] }) ```
Passed 98 restarts and then hit the 2 hour timeout correctly: http://assam.suse.cz/tests/131.
mnowaksuse
force-pushed
the
disable_serial_console_on_shutdown
branch
from
182f219
to
ceb9fd7
Compare
okurz
approved these changes
Jan 4, 2018
|
LGTM, |
This was referenced Jan 4, 2018
mnowaksuse
pushed a commit
to mnowaksuse/os-autoinst-distri-opensuse
that referenced
this pull request
Jan 12, 2018
In PR os-autoinst#4107 we stop serial line grab to get rid of stalls on Xen, however I forgot to start serial line grab afterwards for non-Xen svirt runs. Fails here: https://openqa.suse.de/tests/1381066#step/console_reboot/13 Validation run: http://assam.suse.cz/tests/255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes poo#16418: "svirt: openQA won't perform another query_isotovideo
check when VM is down -> incompletes" (second part in os-autoinst).
Validation run: http://assam.suse.cz/tests/95 (restarted 20 times in
revive_xen_domain test module).
Requires this PR to be deployed to OSD: os-autoinst/os-autoinst#899