Add keyboard layout test to Installer #4308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
force-pushed
the
keyboard_layout_switching_installer
branch
3 times, most recently
from
514e840
to
2349ec6
Compare
|
Non-over engineered version (1 language switch) for graphical and text UI: |
jknphy
force-pushed
the
keyboard_layout_switching_installer
branch
2 times, most recently
from
2920493
to
7729fc3
Compare
jknphy
changed the title
okurz
reviewed
Feb 3, 2018
tests/installation/welcome.pm
Outdated
| @@ -19,6 +19,28 @@ use utils 'ensure_fullscreen'; | |||
| use version_utils qw(is_sle sle_version_at_least); | |||
| use main_common 'is_staging'; | |||
|
|
|||
| sub check_keyboard_layout { | |||
| if (get_var('INSTALL_KEYBOARD_LAYOUT')) { | |||
There was a problem hiding this comment.
Instead of wrapping the whole block in an if how about returning early with unless?:
return unless get_var('INSTALL_KEYBOARD_LAYOUT');
…
okurz
reviewed
Feb 3, 2018
tests/installation/welcome.pm
Outdated
| @@ -113,6 +135,7 @@ sub run { | |||
| } | |||
|
|
|||
| assert_screen 'languagepicked'; | |||
| check_keyboard_layout; | |||
There was a problem hiding this comment.
Would it be possible for you to make that an explicit test module rather than "hide" it in "welcome"?
jknphy
force-pushed
the
keyboard_layout_switching_installer
branch
from
7729fc3
to
24a291c
Compare
Needles TW:Verification runs: |
jknphy
force-pushed
the
keyboard_layout_switching_installer
branch
from
24a291c
to
c3e74e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add keyboard layout test to Installer. This functionality could be tested just by switching to only one language, but I wanted to create a function to iterate languages to have more test cover and reuse code. It was not strictly necessary but it helped me to found and issue in some languages, for example in Czech that is using a qwertz keyboard. qemu is mapping keys with /usr/share/qemu/keymaps/cz and /usr/share/qemu/keymaps/en-us and I was able to reproduce why this code cannot achive alt-y once you switch to check in the Installer. Just need to use -k option in qemu to setup properly, meaning even if we test several switch to languages in future if we want to move forward with installer with a different keyboard we need to go in en-us or have available another parameter to use this -k option of qemu, which is not implemented atm in the backend.