Fix adding /boot/zipl partition on s390x #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it worked with /boot due to suggested mounts, so correct mount point was used in the end. It doesn't happen with storage-ng. See [poo#28507](https://progress.opensuse.org/issues/28507).
rwx788
force-pushed
the
28507_lvm_full_encrypt
branch
from
90fb9a5
to
58c3237
Compare
|
@Soulofdestiny, please, take a look. |
|
uhm in general, looks good - but your verification runs are actually not verifying that it can really boot :) |
|
I know, because it fails before. One of the runs is old behavior, so if it doesn't boot it's a bug. With separate boot, it should work also, as partitioning is according to the specs. ATM it's wrong partitioning. |
|
then let's conduct this experiment? or would it be another case of "merging too early"? ;) |
no, because it's limited to s390x and only the special partitioning module :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it worked with /boot due to suggested mounts, so correct
mount point was used in the end. It doesn't happen with storage-ng.
separate boot
no separate boot