s390x: reselect svirt console to extract SUT pty #4369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Feb 7, 2018
lib/utils.pm
Outdated
| @@ -114,6 +114,9 @@ sub unlock_if_encrypted { | |||
| return unless get_var("ENCRYPT"); | |||
|
|
|||
| if (check_var('ARCH', 's390x') && check_var('BACKEND', 'svirt')) { | |||
| # we need to reset the svirt console to extract the pty variable correctly | |||
| console('svirt')->reset; | |||
| select_console('svirt'); | |||
There was a problem hiding this comment.
IIUC the wrong location. It needs to be set whenever we reboot machines not here
There was a problem hiding this comment.
yeah - also discussed with @rwx788, makes sense to move to redefine_svirt_domain
Soulofdestiny
force-pushed
the
check_s390_lvm_full_encrypt
branch
from
603d8cb
to
1a16a16
Compare
|
changed - new verification run: http://opeth/tests/70 |
Soulofdestiny
force-pushed
the
check_s390_lvm_full_encrypt
branch
from
1a16a16
to
e13d0cd
Compare
|
new verification run passed |
|
why is http://opeth/tests/70#step/boot_encrypt/2 still red then? and can you explain again why we have all these black screenshots in http://opeth/tests/70#step/redefine_svirt_domain/1 ? I thought we tried to avoid these. Maybe @coolo can help us understand? |
|
that's indeed a good question - it timed out... but passphrase was typed... |
|
not needed anymore, was fixed in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verification run: http://opeth/tests/70
@rwx788 @nicksinger
@mnowaksuse maybe also interesting for you - though it should not influence other svirt tests