Fix race condition in assert_and_click_until_screen_change #4397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable but changes like these can have a bigger impact and failures are hard to relate to that change. I strongly recommend to have multiple verification runs here. But of course anyone could do this for this PR, e.g. when you don't have a machine available for that. |
Whenever the release causes multiple screen changes (e.g. "change in button appearance" and "new screen after event", the check_screen may misdetect a successful click. A screen change is signaled by the wait_screen_change return code, which can be used to detect events caused by the click. See poo#31327 Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
StefanBruens
force-pushed
the
fix_race_in_assert_and_click_until_screen_change
branch
from
eeabc9c
to
1ef7e62
Compare
|
@okurz I would appreciate if you would do that (or poke someone else ...) |
|
That actually is a very convincing argument ;) On it. |
|
Conducted more than ten runs, all fine, e.g. http://lord.arch/tests/540 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the release causes multiple screen changes (e.g. "change in
button appearance" and "new screen after event", the check_screen may
misdetect a successful click.
A screen change is signaled by the wait_screen_change return code, which
can be used to detect events caused by the click.
See poo#31327
Signed-off-by: Stefan Brüns stefan.bruens@rwth-aachen.de