Adjust SCC registration yast test for SLE15 #4431
Conversation
| sub run { | ||
| my ($self) = @_; | ||
| x11_start_program('xterm'); | ||
| sub prepare_reg_sle12 { |
There was a problem hiding this comment.
how about having single function prepare_reg which check version inside ?
There was a problem hiding this comment.
I've wrapped it in test_setup already, so don't really want to put it in one piece of code.
lib/y2x11test.pm
Outdated
| @@ -34,6 +34,9 @@ sub launch_yast2_module_x11 { | |||
| type_password; | |||
| send_key 'ret'; | |||
| assert_screen $args{target_match}, $args{match_timeout}; | |||
| # Uses hotkey for gnome, adjust if need for other desktop | |||
| send_key 'alt-f10' if $args{maximize_window}; | |||
|
|
|||
There was a problem hiding this comment.
delete blank line before end of function
| @@ -34,6 +34,9 @@ sub launch_yast2_module_x11 { | |||
| type_password; | |||
| send_key 'ret'; | |||
| assert_screen $args{target_match}, $args{match_timeout}; | |||
| # Uses hotkey for gnome, adjust if need for other desktop | |||
| send_key 'alt-f10' if $args{maximize_window}; | |||
There was a problem hiding this comment.
Please update POD. What do we need this feature for? I assume because of the potentially long list of modules which should all fit but even in this case you can not be sure all is shown so does it really help?
There was a problem hiding this comment.
As of now it fits and that's why I've added here. We use same method for this test which is used for the registration during installation. So verifying that modules are pre-selected by single modules is not supported.
| sub test_setup { | ||
| select_console 'root-console'; | ||
| if (sle_version_at_least '15') { | ||
| prepare_reg_sle15; |
There was a problem hiding this comment.
so this will still be called for SLE16 but calls a function "reg_sle15"? Somehow does not fit nicely. Better call the functions with a name reflecting what they really do
rwx788
force-pushed
the
29423_registartion
branch
2 times, most recently
from
bda4b65
to
89f1e42
Compare
|
@okurz anything else here, or we can merge? |
| sub define_proxy_scc_for_addons { | ||
|
|
||
|
|
||
| } |
There was a problem hiding this comment.
I moved those inline, thanks!
|
|
||
| sub clean_registration_define_proxy_scc_for_all { | ||
|
|
||
| } |
There was a problem hiding this comment.
same as above, still in wip?
The main issue here was that we use already registered image. Nevertheless, we can simply clean registration data and perform clean registration again. See [poo#29423](https://progress.opensuse.org/issues/29423).
rwx788
force-pushed
the
29423_registartion
branch
from
89f1e42
to
cfe560e
Compare
The main issue here was that we use already registered image.
Nevertheless, we can simply clean registration data and perform clean
registration again.
See poo#29423.
Needles.